Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field

Alex Williamson
2010-06-10T15:21:59Z

On Thu, 2010-06-10 at 15:49 +0100, Paul Brook wrote:
> > On Thu, 2010-06-10 at 10:23 +0200, Gerd Hoffmann wrote:
> > > > I may have been a bit misleading here. What we really want to do is use
> > > > the same matching algorithm as is used by the rest of the device
> > > > state. Currently this is a vmstate name and [arbitrary] numeric id. I
> > > > don't remember whether there's a convenient link from a device to its
> > > > associated vmstate - if there isn't there probably should be.
> > >
> > > DeviceState->info->vmsd->name for the name.
> > > Dunno about the numeric id, I think savevm.c doesn't export it.
> >
> > Ok, we can certainly do <vmsd->name>.<vmsd->instance>\<driver string>.
> > It seems like this highlights a deficiency in the vmstate matching
>
> Why are you forcing this to be a string?

It seemed like a good way to send an identifier. What do you suggest?

Alex