Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field

Anthony Liguori
2010-06-09T02:41:00Z

On 06/08/2010 09:30 PM, Paul Brook wrote:
>> The offset given to a block created via qemu_ram_alloc/map() is arbitrary,
>> let the caller specify a name so we can make a positive match.
>>
>
>> @@ -1924,7 +1925,9 @@ static int pci_add_option_rom(PCIDevice *pdev)
>> + snprintf(name, sizeof(name), "pci:%02x.%x.rom",
>> + PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn));
>> + pdev->rom_offset = qemu_ram_alloc(name, size);
>>
> This looks pretty bogus. It should be associated with the device, rather than
> incorrectly trying to generate a globally unique name.
>

Not all ram is associated with a device.

For instance, the base ram for a guest.

Regards,

Anthony Liguori

> Paul
>
>