From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Brook Subject: Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field Date: Wed, 9 Jun 2010 03:54:02 +0100 Message-ID: <201006090354.05197.paul@codesourcery.com> References: <20100608191447.4451.47795.stgit@localhost.localdomain> <201006090330.10324.paul@codesourcery.com> <4C0EFF39.9070602@codemonkey.ws> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, chrisw@redhat.com, Alex Williamson , kvm@vger.kernel.org, quintela@redhat.com To: Anthony Liguori Return-path: Received: from mail.codesourcery.com ([38.113.113.100]:42684 "EHLO mail.codesourcery.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751548Ab0FICzE (ORCPT ); Tue, 8 Jun 2010 22:55:04 -0400 In-Reply-To: <4C0EFF39.9070602@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: > On 06/08/2010 09:30 PM, Paul Brook wrote: > >> The offset given to a block created via qemu_ram_alloc/map() is > >> arbitrary, let the caller specify a name so we can make a positive > >> match. > >> > >> > >> @@ -1924,7 +1925,9 @@ static int pci_add_option_rom(PCIDevice *pdev) > >> + snprintf(name, sizeof(name), "pci:%02x.%x.rom", > >> + PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn)); > >> + pdev->rom_offset = qemu_ram_alloc(name, size); > > > > This looks pretty bogus. It should be associated with the device, rather > > than incorrectly trying to generate a globally unique name. > > Not all ram is associated with a device. Maybe not, but where it is we should be using that information. Absolute minimum we should be using the existing qdev address rather than inventing a new one. Duplicating this logic inside every device seems like a bad idea so I suggest identifying ram blocks by a (name, device) pair. For now we can allow a NULL device for system memory. Paul