From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [RFC v2] [PATCH 0/3] Monitor Support for 'simple'
 trace backend
Date: Fri, 11 Jun 2010 14:56:01 -0300
Message-ID: <20100611145601.64a1a31b@redhat.com>
References: <20100611003811.2635fa5d@zephyr>
	<m37hm5lrrr.fsf@blackfin.pond.sub.org>
	<4C122758.4020808@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Markus Armbruster <armbru@redhat.com>,
	Prerna Saxena <prerna@linux.vnet.ibm.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"maneesh@linux.vnet.ibm.com" <maneesh@linux.vnet.ibm.com>,
	"ananth@linux.vnet.ibm.com" <ananth@linux.vnet.ibm.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:23180 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753802Ab0FKR4L (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 11 Jun 2010 13:56:11 -0400
In-Reply-To: <4C122758.4020808@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, 11 Jun 2010 14:08:56 +0200
Jan Kiszka <jan.kiszka@siemens.com> wrote:

> Markus Armbruster wrote:
> > Prerna Saxena <prerna@linux.vnet.ibm.com> writes:
> > 
> >> This is v2 of monitor commands based on Stefan's trace framework :
> >> ( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html )
> >>
> >> This adds the following monitor commands for the 'simple' backend:
> >> - info trace 		: to view current contents of the trace buffer.
> >> - info tracepoints 	: to view all available tracepoints and their 
> >> 			  state.
> >> - tracepoint NAME on|off: to enable/disable the logging of data from 
> >> 			  tracepoint 'NAME'.
> >>
> >>
> >> Changelog :
> >> - Command 'info trace' is used to view current contents of buffer, in 
> >> place of 'trace'.
> >> - Cleanups
> > 
> > Do we want this in QMP?
> 
> For sure IMO. Maybe not in a hurry to avoid breakages until the whole
> tracing infrastructure has settled, but long-term to ease scripting etc.

 Yeah, that's why I didn't suggest it in my review.

> Still, let's not add this as an old-style monitor command, rather
> convert it to the new style, maybe blocking QMP for now. I'll post the
> required infrastructure for that blocking along my next device_show
> series (hopefully the next days).

 Agreed.