From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Brook Subject: Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field Date: Fri, 11 Jun 2010 17:12:35 +0100 Message-ID: <201006111712.35756.paul@codesourcery.com> References: <20100608191447.4451.47795.stgit@localhost.localdomain> <4C11F858.4050904@redhat.com> <1276271431.3100.26.camel@x201> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Gerd Hoffmann , Anthony Liguori , qemu-devel@nongnu.org, chrisw@redhat.com, kvm@vger.kernel.org, quintela@redhat.com To: Alex Williamson Return-path: Received: from mail.codesourcery.com ([38.113.113.100]:35612 "EHLO mail.codesourcery.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751823Ab0FKQNj (ORCPT ); Fri, 11 Jun 2010 12:13:39 -0400 In-Reply-To: <1276271431.3100.26.camel@x201> Sender: kvm-owner@vger.kernel.org List-ID: > The trouble I'm running into is that the SaveStateEntry.instance_id is > effectively private, and there's no easy way to associate a > SaveStateEntry to a device since it passes an opaque pointer, which > could be whatever the driver decides it wants. I'm wondering if we > should pass the DeviceState pointer in when registering the vmstate so > that we can stuff the instance_id into the DeviceInfo. Or maybe > DeviceInfo should include a pointer to the SaveStateEntry. It all seems > pretty messy. Any thoughts? DeviceInfo is effectively a const structure (it may be modified at startup, but there's only one of it shared between multiple devices). I suspect you mean DeviceState. Most likely a lot of the messyness is because we still have devices that have not been qdev-ified, so the VMState code can't assume it has a device. We should fix this. Paul