From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sheng Yang <sheng@linux.intel.com>
Subject: Re: [PATCH v4] test: Add XSAVE unit test
Date: Sun, 13 Jun 2010 16:47:06 +0800
Message-ID: <201006131647.06469.sheng@linux.intel.com>
References: <4C14940D.1050900@redhat.com> <1276417937-6191-1-git-send-email-sheng@linux.intel.com> <4C149A3E.5000004@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mga11.intel.com ([192.55.52.93]:35595 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753016Ab0FMIqJ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 13 Jun 2010 04:46:09 -0400
In-Reply-To: <4C149A3E.5000004@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sunday 13 June 2010 16:43:42 Avi Kivity wrote:
> On 06/13/2010 11:32 AM, Sheng Yang wrote:
> > Based on IDT test framework.
> > +
> > +int main(void)
> > +{
> > +    setup_idt();
> > +    if (check_cpuid_1_ecx(CPUID_1_ECX_XSAVE)) {
> > +        printf("CPU has XSAVE feature\n");
> > +        test_xsave();
> > +    } else {
> > +        printf("CPU don't has XSAVE feature\n");
> > +        test_no_xsave();
> > +    }
> > +    printf("Total test: %d\n", total_tests);
> > +    if (fail_tests == 0)
> > +        printf("ALL PASS!\n");
> > +    else {
> > +        printf("Fail %d tests.\n", fail_tests);
> > +        return 0;
> > +    }
> > +    return 1;
> > +}
> 
> Wrong way, 0 = success, !0 = fail (just like shell exit codes).

Indeed oops. Finally checked your first comment to this test case patch, and found 
I completely misread it...

--
regards
Yang, Sheng