Re: [PATCH 0/3]: Fixes to IRQ routing

[Gleb Natapov <gleb@redhat.com>]

On Thu, Jun 10, 2010 at 04:44:04PM -0400, Chris Lalancette wrote:
> As we've discussed previously, here is a series of patches to
> fix some of the IRQ routing issues we have in KVM.  With this series
> in place I was able to successfully kdump a RHEL-5 64-bit, and RHEL-6
> 32- and 64-bit guest on CPU's other than the BSP.  RHEL-5 32-bit kdump still
> does not work; it gets stuck on "Checking 'hlt' instruction".  However,
> it does that both before and after this series, so there is something
> else going on there that I still have to debug.
> 
> I also need to change the "kvm_migrate_pit_timer" function to migrate the
> timer over to the last CPU that handled the timer interrupt, on the
> theory that that particlar CPU is likely to handle the timer interrupt again
> in the near future.
> 
> Changes since RFC:
>      - Changed ps->inject_lock from raw_spinlock_t to spinlock_t
>      - Fixed up some formatting issues
>      - Changed to have one PIT workqueue per-guest
>      - Remember to cancel_work_sync when destroying the PIT
> 
> Chris Lalancette
> 
Looks good to me.

--
			Gleb.