From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH 0/3]: Fixes to IRQ routing Date: Mon, 14 Jun 2010 14:21:40 +0300 Message-ID: <20100614112140.GF21797@redhat.com> References: <1276202647-1598-1-git-send-email-clalance@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Chris Lalancette Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58748 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750874Ab0FNLVm (ORCPT ); Mon, 14 Jun 2010 07:21:42 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5EBLgFx031790 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 14 Jun 2010 07:21:42 -0400 Content-Disposition: inline In-Reply-To: <1276202647-1598-1-git-send-email-clalance@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Jun 10, 2010 at 04:44:04PM -0400, Chris Lalancette wrote: > As we've discussed previously, here is a series of patches to > fix some of the IRQ routing issues we have in KVM. With this series > in place I was able to successfully kdump a RHEL-5 64-bit, and RHEL-6 > 32- and 64-bit guest on CPU's other than the BSP. RHEL-5 32-bit kdump still > does not work; it gets stuck on "Checking 'hlt' instruction". However, > it does that both before and after this series, so there is something > else going on there that I still have to debug. > > I also need to change the "kvm_migrate_pit_timer" function to migrate the > timer over to the last CPU that handled the timer interrupt, on the > theory that that particlar CPU is likely to handle the timer interrupt again > in the near future. > > Changes since RFC: > - Changed ps->inject_lock from raw_spinlock_t to spinlock_t > - Fixed up some formatting issues > - Changed to have one PIT workqueue per-guest > - Remember to cancel_work_sync when destroying the PIT > > Chris Lalancette > Looks good to me. -- Gleb.