From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v3] qemu: kvm: Enable XSAVE live migration support Date: Wed, 16 Jun 2010 13:05:44 -0300 Message-ID: <20100616160544.GA3826@amt.cnet> References: <1276231009-6060-1-git-send-email-sheng@linux.intel.com> <20100614203926.GA6316@amt.cnet> <4C18F25E.8070704@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sheng Yang , Avi Kivity , Anthony Liguori , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38500 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932510Ab0FPQzw (ORCPT ); Wed, 16 Jun 2010 12:55:52 -0400 Content-Disposition: inline In-Reply-To: <4C18F25E.8070704@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jun 16, 2010 at 05:48:46PM +0200, Jan Kiszka wrote: > Marcelo Tosatti wrote: > > On Fri, Jun 11, 2010 at 12:36:49PM +0800, Sheng Yang wrote: > >> Signed-off-by: Sheng Yang > >> --- > >> qemu-kvm-x86.c | 109 ++++++++++++++++++++++++++++++++++++++++--------- > >> qemu-kvm.c | 24 +++++++++++ > >> qemu-kvm.h | 28 +++++++++++++ > >> target-i386/cpu.h | 5 ++ > >> target-i386/kvm.c | 2 + > >> target-i386/machine.c | 20 +++++++++ > >> 6 files changed, 169 insertions(+), 19 deletions(-) > > > > Applied, thanks. > > Oops, late remark: Why introducing this feature against qemu-kvm instead > of upstream? Doesn't this just generate additional conversion work and > the risk of divergence to upstream in the migration protocol? Thats true. Sheng, can you add save/restore support to uq/master to avoid these problems? Then the cpuid bits can be also merged upstream.