public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Chris Wright <chrisw@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] Re: KVM call minutes for June 15
Date: Thu, 17 Jun 2010 07:15:32 +0200	[thread overview]
Message-ID: <20100617051532.GA3086@hall.aurel32.net> (raw)
In-Reply-To: <20100615154153.GA2707@infradead.org>

On Tue, Jun 15, 2010 at 11:41:53AM -0400, Christoph Hellwig wrote:
> On Tue, Jun 15, 2010 at 08:18:12AM -0700, Chris Wright wrote:
> > KVM/qemu patches
> > - patch rate is high, documentation is low, review is low
> > - patches need to include better descriptions and documentation
> >   - will slow down patch writers
> >   - will make it easier for patch reviewers
> 
> What is the qemu patch review policy anyway?  There are no
> "Reviewed-by:" included in the actual commits, and the requirement
> for a positive review also seem to vary a lot, up to the point that
> some commiters commit code that has never hit a public mailing list
> before.
> 

This is indeed something very useful that should be encouraged.
Depending on the patch and the persons that have reviewed/acked it, I
commit some patches only after a very quick look.

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

  parent reply	other threads:[~2010-06-17  5:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-15 15:18 KVM call minutes for June 15 Chris Wright
2010-06-15 15:41 ` Christoph Hellwig
2010-06-15 16:13   ` Anthony Liguori
2010-06-16  6:55     ` [Qemu-devel] " Markus Armbruster
2010-06-16  8:58       ` Yoshiaki Tamura
2010-06-16 11:55       ` Arnd Bergmann
2010-06-16 18:07     ` Blue Swirl
2010-06-17  5:15   ` Aurelien Jarno [this message]
2010-06-16  8:58 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100617051532.GA3086@hall.aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=chrisw@redhat.com \
    --cc=hch@infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox