Re: [Qemu-devel] Re: KVM call minutes for June 15

Markus Armbruster
2010-06-16T06:55:09Z

Anthony Liguori <anthony@codemonkey.ws> writes:

> On 06/15/2010 10:41 AM, Christoph Hellwig wrote:
>> On Tue, Jun 15, 2010 at 08:18:12AM -0700, Chris Wright wrote:
>>
>>> KVM/qemu patches
>>> - patch rate is high, documentation is low, review is low
>>> - patches need to include better descriptions and documentation
>>> - will slow down patch writers
>>> - will make it easier for patch reviewers
>>>
>> What is the qemu patch review policy anyway?
>
> We don't really have a coherent policy. Suggestions for improvement
> are always appreciated.
>
>> There are no
>> "Reviewed-by:" included in the actual commits,
>
> Reviewed-by/Ack-by's are pretty helpful for me. In terms of including
> them in commit messages, if there's a strong feeling that that would
> be helpful then it's something I can look at doing but it also
> requires a fair bit of manual work during commit.

Can't hurt reviewer motivation. Could it be automated? Find replies,
extract tags. If you want your acks to be picked up, you better make
sure your References header works, and your tags are formatted
correctly. …