From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [PATCH v3] qemu: kvm: Enable XSAVE live migration support Date: Thu, 17 Jun 2010 10:01:59 +0800 Message-ID: <201006171001.59401.sheng@linux.intel.com> References: <1276231009-6060-1-git-send-email-sheng@linux.intel.com> <4C18F25E.8070704@siemens.com> <20100616160544.GA3826@amt.cnet> Mime-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Avi Kivity , Anthony Liguori , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Jan Kiszka Return-path: Received: from mga14.intel.com ([143.182.124.37]:41711 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754541Ab0FQCBp (ORCPT ); Wed, 16 Jun 2010 22:01:45 -0400 In-Reply-To: <20100616160544.GA3826@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On Thursday 17 June 2010 00:05:44 Marcelo Tosatti wrote: > On Wed, Jun 16, 2010 at 05:48:46PM +0200, Jan Kiszka wrote: > > Marcelo Tosatti wrote: > > > On Fri, Jun 11, 2010 at 12:36:49PM +0800, Sheng Yang wrote: > > >> Signed-off-by: Sheng Yang > > >> --- > > >> > > >> qemu-kvm-x86.c | 109 > > >> ++++++++++++++++++++++++++++++++++++++++--------- qemu-kvm.c > > >> | 24 +++++++++++ > > >> qemu-kvm.h | 28 +++++++++++++ > > >> target-i386/cpu.h | 5 ++ > > >> target-i386/kvm.c | 2 + > > >> target-i386/machine.c | 20 +++++++++ > > >> 6 files changed, 169 insertions(+), 19 deletions(-) > > > > > > Applied, thanks. > > > > Oops, late remark: Why introducing this feature against qemu-kvm instead > > of upstream? Doesn't this just generate additional conversion work and > > the risk of divergence to upstream in the migration protocol? Hi Jan You're late... Hope you could raise the comment earlier next time so we can work together more efficient. > > Thats true. Sheng, can you add save/restore support to uq/master to > avoid these problems? Yes, there is divergence risk, would send an upstream version as well. But I think as long as qemu-kvm and qemu upstream use different LM path, the duplicate code/work can't be avoid. > Then the cpuid bits can be also merged upstream. -- regards Yang, Sheng