From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Harper Subject: Re: [PATCH 2/2] Remove virtio_blk VBID ioctl Date: Sun, 20 Jun 2010 21:30:24 -0500 Message-ID: <20100621023024.GE1647@us.ibm.com> References: <1276886283-1571-1-git-send-email-ryanh@us.ibm.com> <1276886283-1571-2-git-send-email-ryanh@us.ibm.com> <201006211100.19719.rusty@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ryan Harper , virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, qemu-devel@nongnu.org, john cooper To: Rusty Russell Return-path: Received: from e9.ny.us.ibm.com ([32.97.182.139]:44261 "EHLO e9.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757800Ab0FUCab (ORCPT ); Sun, 20 Jun 2010 22:30:31 -0400 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by e9.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id o5L2FUdQ025911 for ; Sun, 20 Jun 2010 22:15:30 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o5L2UUKS143858 for ; Sun, 20 Jun 2010 22:30:30 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o5L2UTkY031673 for ; Sun, 20 Jun 2010 23:30:30 -0300 Content-Disposition: inline In-Reply-To: <201006211100.19719.rusty@rustcorp.com.au> Sender: kvm-owner@vger.kernel.org List-ID: * Rusty Russell [2010-06-20 20:31]: > On Sat, 19 Jun 2010 04:08:03 am Ryan Harper wrote: > > With the availablility of a sysfs device attribute for examining disk serial > > numbers the ioctl is no longer needed. The user-space changes for this aren't > > upstream yet so we don't have any users to worry about. > > If John Cooper acks this, I'll push it to Linus immediately. > > Unfortunately we offered this interface in 2.6.34, and we're now removing it. > That's unpleasant. Yes; well. There's a story as there always is. John can tell it better than I, but it goes something like: John cooked up some patches, one of which was an example use of the serial string including a VBID ioctl. No one got around to doing a sysfs interface and somehow the ioctl side in virtio-blk got picked up. Working with what was available, I pushed some patches to linux-hotplug to get this whole virtio-blk serial and disk/by-id symlinks working and was met with: why does a new kernel driver have an ioctl interface and we don't want to collect additional single-use binaries in the udev tree. So now, the sysfs serial attribute patch and with it, no need and no users of ioctl. *whew* > > Thanks, > Rusty. > PS. John should have been cc'd on these patches! He's cc'ed on the others, just not on this removal one. I need to learn git-send-email better, I explicitly added him as --cc on when sending; next time I'll look closer at the headers during --dry-run. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ryanh@us.ibm.com