From: Gleb Natapov <gleb@redhat.com>
To: avi@redhat.com, mtosatti@redhat.com
Cc: kvm@vger.kernel.org
Subject: [PATCH] do not enter vcpu again if it was stopped during IO
Date: Mon, 21 Jun 2010 12:01:52 +0300 [thread overview]
Message-ID: <20100621090152.GG4689@redhat.com> (raw)
To prevent reentering vcpu after IO completion it is not enough
to set env->stopped since it is checked only in main loop but control
will not get there until next non-IO exit since kvm_run() will reenter
vcpu to complete IO instruction. Solve this by sending self-signal to
request exit after IO instruction completion.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
diff --git a/qemu-kvm.c b/qemu-kvm.c
index be1dac2..4f7cf6d 100644
--- a/qemu-kvm.c
+++ b/qemu-kvm.c
@@ -603,6 +603,10 @@ int kvm_run(CPUState *env)
r = pre_kvm_run(kvm, env);
if (r)
return r;
+ if (env->exit_request) {
+ env->exit_request = 0;
+ pthread_kill(env->kvm_cpu_state.thread, SIG_IPI);
+ }
r = ioctl(fd, KVM_RUN, 0);
if (r == -1 && errno != EINTR && errno != EAGAIN) {
diff --git a/vl.c b/vl.c
index 9e9c176..dcfab13 100644
--- a/vl.c
+++ b/vl.c
@@ -1817,6 +1817,7 @@ void qemu_system_reset_request(void)
}
if (cpu_single_env) {
cpu_single_env->stopped = 1;
+ cpu_exit(cpu_single_env);
}
qemu_notify_event();
}
--
Gleb.
next reply other threads:[~2010-06-21 9:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 9:01 Gleb Natapov [this message]
2010-06-21 20:43 ` [PATCH] do not enter vcpu again if it was stopped during IO Marcelo Tosatti
2010-06-22 5:18 ` Gleb Natapov
2010-06-22 13:59 ` Marcelo Tosatti
2010-06-23 8:22 ` Avi Kivity
2010-06-23 8:24 ` Gleb Natapov
2010-06-23 10:16 ` Jan Kiszka
2010-06-23 10:21 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100621090152.GG4689@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox