From: Gleb Natapov <gleb@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH] do not enter vcpu again if it was stopped during IO
Date: Wed, 23 Jun 2010 11:24:06 +0300 [thread overview]
Message-ID: <20100623082406.GC4689@redhat.com> (raw)
In-Reply-To: <4C21C437.7050302@redhat.com>
On Wed, Jun 23, 2010 at 11:22:15AM +0300, Avi Kivity wrote:
> On 06/21/2010 12:01 PM, Gleb Natapov wrote:
> >To prevent reentering vcpu after IO completion it is not enough
> >to set env->stopped since it is checked only in main loop but control
> >will not get there until next non-IO exit since kvm_run() will reenter
> >vcpu to complete IO instruction. Solve this by sending self-signal to
> >request exit after IO instruction completion.
> >
>
> Applied, thanks.
>
> Does uq/master need such a patch?
>
The code is very different there. I looks to me broken too, but the fix
will be different.
--
Gleb.
next prev parent reply other threads:[~2010-06-23 8:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 9:01 [PATCH] do not enter vcpu again if it was stopped during IO Gleb Natapov
2010-06-21 20:43 ` Marcelo Tosatti
2010-06-22 5:18 ` Gleb Natapov
2010-06-22 13:59 ` Marcelo Tosatti
2010-06-23 8:22 ` Avi Kivity
2010-06-23 8:24 ` Gleb Natapov [this message]
2010-06-23 10:16 ` Jan Kiszka
2010-06-23 10:21 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100623082406.GC4689@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox