From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Hajnoczi Subject: Re: [RFC v4][PATCH 0/3] Monitor support for Qemu tracing Date: Thu, 24 Jun 2010 16:13:13 +0100 Message-ID: <20100624151313.GA10152@stefan-thinkpad.transitives.com> References: <20100624164930.7859b779@zephyr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: qemu-devel@nongnu.org, Anthony Liguori , Jan Kiszka , Maneesh Soni , Luiz Capitulino , kvm@vger.kernel.org, Ananth Narayan To: Prerna Saxena Return-path: Received: from mtagate5.uk.ibm.com ([194.196.100.165]:36435 "EHLO mtagate5.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754511Ab0FXPNY (ORCPT ); Thu, 24 Jun 2010 11:13:24 -0400 Received: from d06nrmr1806.portsmouth.uk.ibm.com (d06nrmr1806.portsmouth.uk.ibm.com [9.149.39.193]) by mtagate5.uk.ibm.com (8.13.1/8.13.1) with ESMTP id o5OFDF5A003103 for ; Thu, 24 Jun 2010 15:13:15 GMT Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o5OFDFVc1618162 for ; Thu, 24 Jun 2010 16:13:15 +0100 Received: from d06av04.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o5OFDEmT030758 for ; Thu, 24 Jun 2010 16:13:15 +0100 Content-Disposition: inline In-Reply-To: <20100624164930.7859b779@zephyr> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Jun 24, 2010 at 04:49:30PM +0530, Prerna Saxena wrote: > This set of patches enables trace visualization & control > via the QEMU monitor. It is based on trace infrastructure posted > upstream : > ( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html ) > > This patchset adds monitor commands : > - info trace : to view current contents of the trace buffer > - info tracepoints : to view all available tracepoints and their state. > - tracepoint NAME on|off : to enable/disable the logging of dataThis is v3 of a set of patches to enable trace visualization & control > via the QEMU monitor. > > Changelog from v3: > 1. As suggested, it replaces a hash-based search of tracepoints > with a linear search. > 2. Static initialization of trace event array. > 3. Cleanups. > > Changelog from v2: > 1. Clean-ups, particularly relating to export of tdb_hash(). > > Changelog from v1: > 1. Command 'info trace' is used to view current contents of buffer, in > place of 'trace'. > 2. Cleanups Applied, thanks! http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/tracing I'd like to focus on polishing the current tracing branch into a patchset that can be merged into QEMU. Having this working prototype enables us to try tracing out; we can commit fixes on top and then squish the commits down for QEMU merge when the basic feature set is solid. > Todos : > 1. Integration with QMP > 2. More tracepoints need to be added for instrumenting other qemu components > such as virtio drivers, etc. I am copying these to another email thread so we can discuss what needs to be done to get tracing merged. Stefan