Re: [PATCH] make-release: fix mtime on rhel6 beta

Eduardo Habkost
2010-06-24T16:12:38Z

On Thu, Jun 24, 2010 at 06:48:52PM +0300, Michael S. Tsirkin wrote:
> With recent git versions (like one in rhel6 beta),
> git prints out tag info in addition to
> requested format, if passed a tag name.
> This breaks make-release.
> To get just the time as we want, we need to
> pass something that is not a tag name but matches
> same commit. $commit~0 does this.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

I suggest using "$commit^{commit}", to make it more clear.

> -mtime=`git show --format=%ct "$commit" --`
> +mtime=`git show --format=%ct "$commit"~0 --`
> tarargs="--owner=root --group=root --mtime=@$mtime"

--
Eduardo