From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] make-release: fix mtime on rhel6 beta Date: Thu, 24 Jun 2010 19:09:15 +0300 Message-ID: <20100624160915.GA11218@redhat.com> References: <20100624154852.GA11139@redhat.com> <20100624161204.GF14947@blackpad.lan.raisama.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, mtosatti@redhat.com, avi@redhat.com To: Eduardo Habkost Return-path: Received: from mx1.redhat.com ([209.132.183.28]:10136 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755083Ab0FXQOJ (ORCPT ); Thu, 24 Jun 2010 12:14:09 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5OGE8G4004865 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 24 Jun 2010 12:14:09 -0400 Content-Disposition: inline In-Reply-To: <20100624161204.GF14947@blackpad.lan.raisama.net> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Jun 24, 2010 at 01:12:04PM -0300, Eduardo Habkost wrote: > On Thu, Jun 24, 2010 at 06:48:52PM +0300, Michael S. Tsirkin wrote: > > With recent git versions (like one in rhel6 beta), > > git prints out tag info in addition to > > requested format, if passed a tag name. > > This breaks make-release. > > To get just the time as we want, we need to > > pass something that is not a tag name but matches > > same commit. $commit~0 does this. > > > > Signed-off-by: Michael S. Tsirkin > > I suggest using "$commit^{commit}", to make it more clear. Since which git version does this work? > > -mtime=`git show --format=%ct "$commit" --` > > +mtime=`git show --format=%ct "$commit"~0 --` > > tarargs="--owner=root --group=root --mtime=@$mtime" > > -- > Eduardo