* [PATCHv2] make-release: fix mtime on rhel6 beta
@ 2010-06-24 17:19 Michael S. Tsirkin
2010-06-28 20:24 ` Marcelo Tosatti
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2010-06-24 17:19 UTC (permalink / raw)
To: avi, kvm, mtosatti, ehabkost
With recent git versions (like one in rhel6 beta),
git prints out tag info in addition to
requested format, if passed a tag name.
This breaks make-release.
To get just the time as we want, we need to
pass something that is not a tag name but matches
same commit. $commit^{commit} does this.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Changes from v1: use ^{commit} for clarity.
kvm/scripts/make-release | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kvm/scripts/make-release b/kvm/scripts/make-release
index e8051f4..64e77f9 100755
--- a/kvm/scripts/make-release
+++ b/kvm/scripts/make-release
@@ -51,7 +51,7 @@ cd "$(dirname "$0")"/../..
mkdir -p "$(dirname "$tarball")"
git archive --prefix="$name/" --format=tar "$commit" > "$tarball"
-mtime=`git show --format=%ct "$commit" --`
+mtime=`git show --format=%ct "$commit""^{commit}" --`
tarargs="--owner=root --group=root --mtime=@$mtime"
mkdir -p "$tmpdir"
--
1.7.1.12.g42b7f
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCHv2] make-release: fix mtime on rhel6 beta
2010-06-24 17:19 [PATCHv2] make-release: fix mtime on rhel6 beta Michael S. Tsirkin
@ 2010-06-28 20:24 ` Marcelo Tosatti
0 siblings, 0 replies; 2+ messages in thread
From: Marcelo Tosatti @ 2010-06-28 20:24 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: avi, kvm, ehabkost
On Thu, Jun 24, 2010 at 08:19:02PM +0300, Michael S. Tsirkin wrote:
> With recent git versions (like one in rhel6 beta),
> git prints out tag info in addition to
> requested format, if passed a tag name.
> This breaks make-release.
> To get just the time as we want, we need to
> pass something that is not a tag name but matches
> same commit. $commit^{commit} does this.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-28 20:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-24 17:19 [PATCHv2] make-release: fix mtime on rhel6 beta Michael S. Tsirkin
2010-06-28 20:24 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox