From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH 0/2] v2: Add 'serial' attribute to virtio-blk devices Date: Fri, 25 Jun 2010 12:34:28 +0930 Message-ID: <201006251234.30808.rusty@rustcorp.com.au> References: <1277349598-24559-1-git-send-email-ryanh@us.ibm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Cc: virtualization@lists.linux-foundation.org, john cooper , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Ryan Harper Return-path: Received: from ozlabs.org ([203.10.76.45]:37133 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754135Ab0FYDEi (ORCPT ); Thu, 24 Jun 2010 23:04:38 -0400 In-Reply-To: <1277349598-24559-1-git-send-email-ryanh@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 24 Jun 2010 12:49:56 pm Ryan Harper wrote: > Using Rusty's suggestion I've respun the patch removing the special copy > function. I've tested this patch in a guest kernel with and without qemu > supplying serial numbers for the block devices and it's working as expected. > When qemu supplies serial numbers, the correct value is supplied to > /sys/block/vdX/serial and can be used by udev for generating disk/by-id paths > (without separate utility). When running without serial number support the path > still exists in sysfs but produces no output. > > Signed-off-by: Ryan Harper Great, both applied. BTW, a mail without a patch doesn't need a sign off, does it? Thanks, Ruty.