From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Cao Subject: Re: [KVM-AUTOTEST PATCH] KVM test: Windows unattended_install: don't start the telnet service at startup Date: Tue, 29 Jun 2010 09:33:40 +0800 Message-ID: <20100629013340.GA3118@t4.rh> References: <1277736858-7654-1-git-send-email-mgoldish@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: autotest@test.kernel.org, kvm@vger.kernel.org To: Michael Goldish Return-path: Received: from mx1.redhat.com ([209.132.183.28]:16477 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750762Ab0F2BdS (ORCPT ); Mon, 28 Jun 2010 21:33:18 -0400 Content-Disposition: inline In-Reply-To: <1277736858-7654-1-git-send-email-mgoldish@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jun 28, 2010 at 05:54:18PM +0300, Michael Goldish wrote: > The telnet service isn't used by kvm-autotest (AFAIK) and may interfere with > rss.exe (port 23). > Michael, I think it is better to leave the port 23 (and also 22) alone, people may want to use both telnet (e.g. telnet is integrited into some testing tools and/or some other reasons) and rss.exe. and rss.exe could use other port and we can configure the port NR through the config file of kvm-autotest to use it. Regards, Cao, Chen 2010/06/29 > Signed-off-by: Michael Goldish > --- > client/tests/kvm/unattended/win2003-32.sif | 10 +++----- > client/tests/kvm/unattended/win2003-64.sif | 10 +++----- > .../kvm/unattended/win2008-32-autounattend.xml | 18 ++------------- > .../kvm/unattended/win2008-64-autounattend.xml | 18 ++------------- > .../kvm/unattended/win2008-r2-autounattend.xml | 18 ++------------- > .../tests/kvm/unattended/win7-32-autounattend.xml | 22 ++++--------------- > .../tests/kvm/unattended/win7-64-autounattend.xml | 22 ++++--------------- > .../kvm/unattended/winvista-32-autounattend.xml | 18 ++------------- > .../kvm/unattended/winvista-64-autounattend.xml | 18 ++------------- > 9 files changed, 33 insertions(+), 121 deletions(-) > > diff --git a/client/tests/kvm/unattended/win2003-32.sif b/client/tests/kvm/unattended/win2003-32.sif > index f58b0b0..d1e8495 100644 > --- a/client/tests/kvm/unattended/win2003-32.sif > +++ b/client/tests/kvm/unattended/win2003-32.sif > @@ -56,9 +56,7 @@ > YResolution=768 > > [GuiRunOnce] > - Command0="cmd /c sc config TlntSvr start= auto" > - Command1="cmd /c netsh firewall set opmode disable" > - Command2="cmd /c net start telnet" > - Command3="cmd /c E:\setuprss.bat" > - Command4="cmd /c netsh interface ip set address local dhcp" > - Command5="cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe" > + Command0="cmd /c netsh firewall set opmode disable" > + Command1="cmd /c E:\setuprss.bat" > + Command2="cmd /c netsh interface ip set address local dhcp" > + Command3="cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe" > diff --git a/client/tests/kvm/unattended/win2003-64.sif b/client/tests/kvm/unattended/win2003-64.sif > index f58b0b0..d1e8495 100644 > --- a/client/tests/kvm/unattended/win2003-64.sif > +++ b/client/tests/kvm/unattended/win2003-64.sif > @@ -56,9 +56,7 @@ > YResolution=768 > > [GuiRunOnce] > - Command0="cmd /c sc config TlntSvr start= auto" > - Command1="cmd /c netsh firewall set opmode disable" > - Command2="cmd /c net start telnet" > - Command3="cmd /c E:\setuprss.bat" > - Command4="cmd /c netsh interface ip set address local dhcp" > - Command5="cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe" > + Command0="cmd /c netsh firewall set opmode disable" > + Command1="cmd /c E:\setuprss.bat" > + Command2="cmd /c netsh interface ip set address local dhcp" > + Command3="cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe" > diff --git a/client/tests/kvm/unattended/win2008-32-autounattend.xml b/client/tests/kvm/unattended/win2008-32-autounattend.xml > index 44a9fc4..74f99b1 100644 > --- a/client/tests/kvm/unattended/win2008-32-autounattend.xml > +++ b/client/tests/kvm/unattended/win2008-32-autounattend.xml > @@ -116,30 +116,18 @@ > > > 1 > - %WINDIR%\System32\cmd /c start /w pkgmgr /iu:"TelnetServer" > - > - > - 2 > - %WINDIR%\System32\cmd /c sc config TlntSvr start= auto > - > - > - 3 > %WINDIR%\System32\cmd /c netsh firewall set opmode disable > > > - 4 > - %WINDIR%\System32\cmd /c net start telnet > - > - > - 5 > + 2 > %WINDIR%\System32\cmd /c E:\setuprss.bat > > > - 6 > + 3 > %WINDIR%\System32\cmd /c netsh interface ip set address "Local Area Connection" dhcp > > > - 7 > + 4 > %WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe > > > diff --git a/client/tests/kvm/unattended/win2008-64-autounattend.xml b/client/tests/kvm/unattended/win2008-64-autounattend.xml > index ea0a524..6e71cfd 100644 > --- a/client/tests/kvm/unattended/win2008-64-autounattend.xml > +++ b/client/tests/kvm/unattended/win2008-64-autounattend.xml > @@ -125,30 +125,18 @@ > > > 1 > - %WINDIR%\System32\cmd /c start /w pkgmgr /iu:"TelnetServer" > - > - > - 2 > - %WINDIR%\System32\cmd /c sc config TlntSvr start= auto > - > - > - 3 > %WINDIR%\System32\cmd /c netsh firewall set opmode disable > > > - 4 > - %WINDIR%\System32\cmd /c net start telnet > - > - > - 5 > + 2 > %WINDIR%\System32\cmd /c E:\setuprss.bat > > > - 6 > + 3 > %WINDIR%\System32\cmd /c netsh interface ip set address "Local Area Connection" dhcp > > > - 7 > + 4 > %WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe > > > diff --git a/client/tests/kvm/unattended/win2008-r2-autounattend.xml b/client/tests/kvm/unattended/win2008-r2-autounattend.xml > index ea0a524..6e71cfd 100644 > --- a/client/tests/kvm/unattended/win2008-r2-autounattend.xml > +++ b/client/tests/kvm/unattended/win2008-r2-autounattend.xml > @@ -125,30 +125,18 @@ > > > 1 > - %WINDIR%\System32\cmd /c start /w pkgmgr /iu:"TelnetServer" > - > - > - 2 > - %WINDIR%\System32\cmd /c sc config TlntSvr start= auto > - > - > - 3 > %WINDIR%\System32\cmd /c netsh firewall set opmode disable > > > - 4 > - %WINDIR%\System32\cmd /c net start telnet > - > - > - 5 > + 2 > %WINDIR%\System32\cmd /c E:\setuprss.bat > > > - 6 > + 3 > %WINDIR%\System32\cmd /c netsh interface ip set address "Local Area Connection" dhcp > > > - 7 > + 4 > %WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe > > > diff --git a/client/tests/kvm/unattended/win7-32-autounattend.xml b/client/tests/kvm/unattended/win7-32-autounattend.xml > index a577a91..39123bf 100644 > --- a/client/tests/kvm/unattended/win7-32-autounattend.xml > +++ b/client/tests/kvm/unattended/win7-32-autounattend.xml > @@ -122,36 +122,24 @@ > > > > - %WINDIR%\System32\cmd /c start /w pkgmgr /iu:"TelnetServer" > - 1 > - > - > - %WINDIR%\System32\cmd /c sc config TlntSvr start= auto > - 2 > - > - > %WINDIR%\System32\cmd /c netsh firewall set opmode disable > - 3 > - > - > - %WINDIR%\System32\cmd /c net start telnet > - 4 > + 1 > > > %WINDIR%\System32\cmd /c E:\setuprss.bat > - 5 > + 2 > > > %WINDIR%\System32\cmd /c netsh interface ip set address "Local Area Connection" dhcp > - 6 > + 3 > > > %WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe > - 7 > + 4 > > > > > xmlns:cpi="urn:schemas-microsoft-com:cpi" /> > - > \ No newline at end of file > + > diff --git a/client/tests/kvm/unattended/win7-64-autounattend.xml b/client/tests/kvm/unattended/win7-64-autounattend.xml > index fec8017..e39b9d7 100644 > --- a/client/tests/kvm/unattended/win7-64-autounattend.xml > +++ b/client/tests/kvm/unattended/win7-64-autounattend.xml > @@ -122,36 +122,24 @@ > > > > - %WINDIR%\System32\cmd /c start /w pkgmgr /iu:"TelnetServer" > - 1 > - > - > - %WINDIR%\System32\cmd /c sc config TlntSvr start= auto > - 2 > - > - > %WINDIR%\System32\cmd /c netsh firewall set opmode disable > - 3 > - > - > - %WINDIR%\System32\cmd /c net start telnet > - 4 > + 1 > > > %WINDIR%\System32\cmd /c E:\setuprss.bat > - 5 > + 2 > > > %WINDIR%\System32\cmd /c netsh interface ip set address "Local Area Connection" dhcp > - 6 > + 3 > > > %WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe > - 7 > + 4 > > > > > xmlns:cpi="urn:schemas-microsoft-com:cpi" /> > - > \ No newline at end of file > + > diff --git a/client/tests/kvm/unattended/winvista-32-autounattend.xml b/client/tests/kvm/unattended/winvista-32-autounattend.xml > index 7835a64..37c6de5 100644 > --- a/client/tests/kvm/unattended/winvista-32-autounattend.xml > +++ b/client/tests/kvm/unattended/winvista-32-autounattend.xml > @@ -123,30 +123,18 @@ > > > 1 > - %WINDIR%\System32\cmd /c start /w pkgmgr /iu:"TelnetServer" > - > - > - 2 > - %WINDIR%\System32\cmd /c sc config TlntSvr start= auto > - > - > - 3 > %WINDIR%\System32\cmd /c netsh firewall set opmode disable > > > - 4 > - %WINDIR%\System32\cmd /c net start telnet > - > - > - 5 > + 2 > %WINDIR%\System32\cmd /c E:\setuprss.bat > > > - 6 > + 3 > %WINDIR%\System32\cmd /c netsh interface ip set address "Local Area Connection" dhcp > > > - 7 > + 4 > %WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe > > > diff --git a/client/tests/kvm/unattended/winvista-64-autounattend.xml b/client/tests/kvm/unattended/winvista-64-autounattend.xml > index ad68bf9..528e6ac 100644 > --- a/client/tests/kvm/unattended/winvista-64-autounattend.xml > +++ b/client/tests/kvm/unattended/winvista-64-autounattend.xml > @@ -124,30 +124,18 @@ > > > 1 > - %WINDIR%\System32\cmd /c start /w pkgmgr /iu:"TelnetServer" > - > - > - 2 > - %WINDIR%\System32\cmd /c sc config TlntSvr start= auto > - > - > - 3 > %WINDIR%\System32\cmd /c netsh firewall set opmode disable > > > - 4 > - %WINDIR%\System32\cmd /c net start telnet > - > - > - 5 > + 2 > %WINDIR%\System32\cmd /c E:\setuprss.bat > > > - 6 > + 3 > %WINDIR%\System32\cmd /c netsh interface ip set address "Local Area Connection" dhcp > > > - 7 > + 4 > %WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe > > > -- > 1.5.4.1 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Regards, Cao, Chen GnuPG Key-ID:AC54E05E keyserver hkp://keys.gnupg.net