From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Avi Kivity <avi@redhat.com>
Cc: Sheng Yang <sheng@linux.intel.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Yaozu (Eddie) Dong" <eddie.dong@intel.com>
Subject: Re: [PATCH v5] KVM: VMX: Execute WBINVD to keep data consistency with assigned devices
Date: Tue, 29 Jun 2010 15:34:56 +0200 [thread overview]
Message-ID: <20100629133455.GE1788@amd.com> (raw)
In-Reply-To: <4C29E897.7090909@redhat.com>
On Tue, Jun 29, 2010 at 08:35:35AM -0400, Avi Kivity wrote:
> On 06/29/2010 03:28 PM, Roedel, Joerg wrote:
>
> The flag indicates to kvm that it doesn't need to worry about iommu
> cache coherency issues (for example, it can ignore wbinvd), so it needs
> to be set. THe following code
>
> if (iommu_domain_has_cap(kvm->arch.iommu_domain,
> IOMMU_CAP_CACHE_COHERENCY))
> kvm->arch.iommu_flags |= KVM_IOMMU_CACHE_COHERENCY;
>
> does this, so it looks like you need to return true for
> iommu_domain_has_cap() after the change. So far only the intel iommu
> supports it.
Ah ok, good to know. Thanks.
Joerg
next prev parent reply other threads:[~2010-06-29 13:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 3:36 [PATCH v3] KVM: VMX: Execute WBINVD to keep data consistency with assigned devices Sheng Yang
2010-06-28 3:56 ` Avi Kivity
2010-06-28 6:42 ` Sheng Yang
2010-06-28 6:56 ` Avi Kivity
2010-06-28 6:56 ` Sheng Yang
2010-06-28 7:08 ` Avi Kivity
2010-06-28 7:41 ` Sheng Yang
2010-06-28 8:07 ` Avi Kivity
2010-06-28 8:42 ` [PATCH v4] " Sheng Yang
2010-06-28 9:27 ` Avi Kivity
2010-06-28 9:31 ` Gleb Natapov
2010-06-28 9:35 ` Avi Kivity
2010-06-29 3:16 ` [PATCH v5] " Sheng Yang
2010-06-29 9:39 ` Avi Kivity
2010-06-29 10:32 ` Jan Kiszka
2010-06-29 10:42 ` Avi Kivity
2010-06-29 12:32 ` Roedel, Joerg
2010-06-29 12:37 ` Avi Kivity
2010-06-29 10:14 ` Roedel, Joerg
2010-06-29 10:44 ` Avi Kivity
2010-06-29 12:28 ` Roedel, Joerg
2010-06-29 12:35 ` Avi Kivity
2010-06-29 13:34 ` Roedel, Joerg [this message]
2010-06-29 13:25 ` Marcelo Tosatti
2010-06-29 13:28 ` Avi Kivity
2010-06-29 13:35 ` Marcelo Tosatti
2010-06-29 13:50 ` Avi Kivity
2010-06-29 14:31 ` Marcelo Tosatti
2010-06-28 7:30 ` [PATCH v3] " Dong, Eddie
2010-06-28 8:04 ` Avi Kivity
2010-06-28 8:16 ` Dong, Eddie
2010-06-28 8:45 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100629133455.GE1788@amd.com \
--to=joerg.roedel@amd.com \
--cc=avi@redhat.com \
--cc=eddie.dong@intel.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox