From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
Subject: Re: [PATCH v5] KVM: VMX: Execute WBINVD to keep data consistency
 with assigned devices
Date: Tue, 29 Jun 2010 15:34:56 +0200
Message-ID: <20100629133455.GE1788@amd.com>
References: <4C286CCE.10309@redhat.com>
 <1277781419-13227-1-git-send-email-sheng@linux.intel.com>
 <20100629101403.GB1788@amd.com>
 <4C29CE89.6010206@redhat.com>
 <20100629122827.GC1788@amd.com>
 <4C29E897.7090909@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: Sheng Yang <sheng@linux.intel.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"Yaozu (Eddie) Dong" <eddie.dong@intel.com>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from va3ehsobe006.messaging.microsoft.com ([216.32.180.16]:24814
	"EHLO VA3EHSOBE009.bigfish.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1755995Ab0F2Ni4 (ORCPT
	<rfc822;kvm@vger.kernel.org>); Tue, 29 Jun 2010 09:38:56 -0400
Content-Disposition: inline
In-Reply-To: <4C29E897.7090909@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Jun 29, 2010 at 08:35:35AM -0400, Avi Kivity wrote:
> On 06/29/2010 03:28 PM, Roedel, Joerg wrote:
> 
> The flag indicates to kvm that it doesn't need to worry about iommu 
> cache coherency issues (for example, it can ignore wbinvd), so it needs 
> to be set.  THe following code
> 
>          if (iommu_domain_has_cap(kvm->arch.iommu_domain,
>                                   IOMMU_CAP_CACHE_COHERENCY))
>                  kvm->arch.iommu_flags |= KVM_IOMMU_CACHE_COHERENCY;
> 
> does this, so it looks like you need to return true for 
> iommu_domain_has_cap() after the change.  So far only the intel iommu 
> supports it.

Ah ok, good to know. Thanks.

	Joerg