* [PATCH] device-assignment: Clear assigned_dev irq type
@ 2010-06-29 17:51 Alex Williamson
2010-06-29 17:55 ` Chris Wright
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Alex Williamson @ 2010-06-29 17:51 UTC (permalink / raw)
To: kvm; +Cc: quintela, chrisw, alex.williamson
Commit 96abccb5 cleared assigned_irq_data.flags when an irq is disabled,
but what we really want is to clear assigned_dev->irq_requested_type.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Found-by: Juan Quintela <quintela@redhat.com>
---
hw/device-assignment.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/device-assignment.c b/hw/device-assignment.c
index 585162b..48ac73c 100644
--- a/hw/device-assignment.c
+++ b/hw/device-assignment.c
@@ -1044,7 +1044,7 @@ static void assigned_dev_update_msi(PCIDevice *pci_dev, unsigned int ctrl_pos)
if (r && r != -ENXIO)
perror("assigned_dev_update_msi: deassign irq");
- assigned_irq_data.flags = 0;
+ assigned_dev->irq_requested_type = 0;
}
if (ctrl_byte & PCI_MSI_FLAGS_ENABLE) {
@@ -1208,7 +1208,7 @@ static void assigned_dev_update_msix(PCIDevice *pci_dev, unsigned int ctrl_pos)
if (r && r != -ENXIO)
perror("assigned_dev_update_msix: deassign irq");
- assigned_irq_data.flags = 0;
+ assigned_dev->irq_requested_type = 0;
}
if (*ctrl_word & PCI_MSIX_ENABLE) {
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] device-assignment: Clear assigned_dev irq type
2010-06-29 17:51 [PATCH] device-assignment: Clear assigned_dev irq type Alex Williamson
@ 2010-06-29 17:55 ` Chris Wright
2010-06-29 18:13 ` Juan Quintela
2010-06-30 16:59 ` Marcelo Tosatti
2 siblings, 0 replies; 4+ messages in thread
From: Chris Wright @ 2010-06-29 17:55 UTC (permalink / raw)
To: Alex Williamson; +Cc: kvm, quintela, chrisw
* Alex Williamson (alex.williamson@redhat.com) wrote:
> Commit 96abccb5 cleared assigned_irq_data.flags when an irq is disabled,
> but what we really want is to clear assigned_dev->irq_requested_type.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> Found-by: Juan Quintela <quintela@redhat.com>
Acked-by: Chris Wright <chrisw@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] device-assignment: Clear assigned_dev irq type
2010-06-29 17:51 [PATCH] device-assignment: Clear assigned_dev irq type Alex Williamson
2010-06-29 17:55 ` Chris Wright
@ 2010-06-29 18:13 ` Juan Quintela
2010-06-30 16:59 ` Marcelo Tosatti
2 siblings, 0 replies; 4+ messages in thread
From: Juan Quintela @ 2010-06-29 18:13 UTC (permalink / raw)
To: Alex Williamson; +Cc: kvm, chrisw
Alex Williamson <alex.williamson@redhat.com> wrote:
> Commit 96abccb5 cleared assigned_irq_data.flags when an irq is disabled,
> but what we really want is to clear assigned_dev->irq_requested_type.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> Found-by: Juan Quintela <quintela@redhat.com>
Acked-by: Juan Quintela <quintela@redhat.com>
> ---
>
> hw/device-assignment.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/device-assignment.c b/hw/device-assignment.c
> index 585162b..48ac73c 100644
> --- a/hw/device-assignment.c
> +++ b/hw/device-assignment.c
> @@ -1044,7 +1044,7 @@ static void assigned_dev_update_msi(PCIDevice *pci_dev, unsigned int ctrl_pos)
> if (r && r != -ENXIO)
> perror("assigned_dev_update_msi: deassign irq");
>
> - assigned_irq_data.flags = 0;
> + assigned_dev->irq_requested_type = 0;
> }
>
> if (ctrl_byte & PCI_MSI_FLAGS_ENABLE) {
> @@ -1208,7 +1208,7 @@ static void assigned_dev_update_msix(PCIDevice *pci_dev, unsigned int ctrl_pos)
> if (r && r != -ENXIO)
> perror("assigned_dev_update_msix: deassign irq");
>
> - assigned_irq_data.flags = 0;
> + assigned_dev->irq_requested_type = 0;
> }
>
> if (*ctrl_word & PCI_MSIX_ENABLE) {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] device-assignment: Clear assigned_dev irq type
2010-06-29 17:51 [PATCH] device-assignment: Clear assigned_dev irq type Alex Williamson
2010-06-29 17:55 ` Chris Wright
2010-06-29 18:13 ` Juan Quintela
@ 2010-06-30 16:59 ` Marcelo Tosatti
2 siblings, 0 replies; 4+ messages in thread
From: Marcelo Tosatti @ 2010-06-30 16:59 UTC (permalink / raw)
To: Alex Williamson; +Cc: kvm, quintela, chrisw
On Tue, Jun 29, 2010 at 11:51:54AM -0600, Alex Williamson wrote:
> Commit 96abccb5 cleared assigned_irq_data.flags when an irq is disabled,
> but what we really want is to clear assigned_dev->irq_requested_type.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> Found-by: Juan Quintela <quintela@redhat.com>
> ---
>
> hw/device-assignment.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-06-30 17:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-29 17:51 [PATCH] device-assignment: Clear assigned_dev irq type Alex Williamson
2010-06-29 17:55 ` Chris Wright
2010-06-29 18:13 ` Juan Quintela
2010-06-30 16:59 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox