From: Marcelo Tosatti <mtosatti@redhat.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Avi Kivity <avi@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH v4 5/6] KVM: MMU: combine guest pte read between walk and pte prefetch
Date: Fri, 2 Jul 2010 14:03:03 -0300 [thread overview]
Message-ID: <20100702170303.GC25969@amt.cnet> (raw)
In-Reply-To: <4C2C9E6C.2040803@cn.fujitsu.com>
On Thu, Jul 01, 2010 at 09:55:56PM +0800, Xiao Guangrong wrote:
> Combine guest pte read between guest pte walk and pte prefetch
>
> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
> ---
> arch/x86/kvm/paging_tmpl.h | 48 ++++++++++++++++++++++++++++++-------------
> 1 files changed, 33 insertions(+), 15 deletions(-)
Can't do this, it can miss invlpg:
vcpu0 vcpu1
read guest ptes
modify guest pte
invlpg
instantiate stale
guest pte
See how the pte is reread inside fetch with mmu_lock held.
Otherwise the patchset looks fine to me.
next prev parent reply other threads:[~2010-07-02 17:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 13:53 [PATCH v4 1/6] KVM: MMU: introduce gfn_to_pfn_atomic() function Xiao Guangrong
2010-07-01 13:53 ` [PATCH v4 2/6] KVM: MMU: introduce gfn_to_page_many_atomic() function Xiao Guangrong
2010-07-01 13:54 ` [PATCH v4 3/6] KVM: MMU: introduce pte_prefetch_topup_memory_cache() Xiao Guangrong
2010-07-01 13:55 ` [PATCH v4 4/6] KVM: MMU: prefetch ptes when intercepted guest #PF Xiao Guangrong
2010-07-02 16:54 ` Marcelo Tosatti
2010-07-03 8:08 ` Xiao Guangrong
2010-07-05 12:01 ` Marcelo Tosatti
2010-07-06 0:50 ` Xiao Guangrong
2010-07-01 13:55 ` [PATCH v4 5/6] KVM: MMU: combine guest pte read between walk and pte prefetch Xiao Guangrong
2010-07-02 17:03 ` Marcelo Tosatti [this message]
2010-07-03 10:31 ` Xiao Guangrong
2010-07-03 12:08 ` Avi Kivity
2010-07-03 12:16 ` Xiao Guangrong
2010-07-03 12:26 ` Avi Kivity
2010-07-03 12:31 ` Xiao Guangrong
2010-07-03 12:44 ` Avi Kivity
2010-07-03 12:49 ` Avi Kivity
2010-07-03 13:03 ` Xiao Guangrong
2010-07-04 14:30 ` Avi Kivity
2010-07-05 2:52 ` Xiao Guangrong
2010-07-05 8:23 ` Avi Kivity
2010-07-05 8:45 ` Xiao Guangrong
2010-07-05 9:05 ` Avi Kivity
2010-07-05 9:09 ` Xiao Guangrong
2010-07-05 9:20 ` Avi Kivity
2010-07-05 9:31 ` Xiao Guangrong
2010-07-03 12:57 ` Xiao Guangrong
2010-07-04 14:32 ` Avi Kivity
2010-07-03 11:48 ` Avi Kivity
2010-07-01 13:56 ` [PATCH v4 6/6] KVM: MMU: trace " Xiao Guangrong
2010-07-02 16:47 ` [PATCH v4 1/6] KVM: MMU: introduce gfn_to_pfn_atomic() function Marcelo Tosatti
2010-07-03 3:13 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100702170303.GC25969@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).