From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: Alt SeaBIOS SSDT cpu hotplug Date: Thu, 8 Jul 2010 15:54:10 +0300 Message-ID: <20100708125410.GU4689@redhat.com> References: <20100707045705.GA3427@morn.localdomain> <20100707102249.GA4689@redhat.com> <20100707232607.GA7778@morn.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: seabios@seabios.org, kvm@vger.kernel.org To: "Kevin O'Connor" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36108 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755189Ab0GHMyb (ORCPT ); Thu, 8 Jul 2010 08:54:31 -0400 Content-Disposition: inline In-Reply-To: <20100707232607.GA7778@morn.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jul 07, 2010 at 07:26:07PM -0400, Kevin O'Connor wrote: > On Wed, Jul 07, 2010 at 01:22:49PM +0300, Gleb Natapov wrote: > > On Wed, Jul 07, 2010 at 12:57:05AM -0400, Kevin O'Connor wrote: > > > The "CPUS" package stores references to the Processor objects, and the > > > "CPON" package stores the state of which cpus are active. With this > > > info, hopefully there is no need to update the MADT tables. > > > > > The way you wrote it acpi_id is always equal to lapic_id which is not > > alway true. By using MADT from memory we remove this dependency from > > DSDT code. > > The current code always sets the apic->processor_id equal to > apic->local_apic_id in the madt apic table. If this changes, we could > add a dynamically created mapping table to the ssdt. Something like: > > Name(CPLA, Package() { 0x00, 0x01, 0x02, 0x03, 0x04 }) > Yeah, but if we can avoid it in the first place why not doing so. BTW how do you pass to DSDT what cpus are initially on? Previously this info was taken from memory copy of MADT too. -- Gleb.