From mboxrd@z Thu Jan  1 00:00:00 1970
From: Brian Jackson <iggy@theiggy.com>
Subject: Re: [PATCH] increase MAX_NICS value
Date: Fri, 9 Jul 2010 12:30:58 -0500
Message-ID: <201007091230.58502.iggy@theiggy.com>
References: <1278689957.9187.12.camel@champagne>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: Alessandro Bono <alessandro.bono@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from theiggy.com ([66.220.1.110]:37772 "EHLO mail.theiggy.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757453Ab0GIRbA (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 9 Jul 2010 13:31:00 -0400
In-Reply-To: <1278689957.9187.12.camel@champagne>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Friday, July 09, 2010 10:39:17 am Alessandro Bono wrote:
> Hi all
> 
> max number of allowed nics per vm is hardcoded on net.h to 8. This value
> it's too low in situation with big network, increase to 24
> this should be safe as mentioned on this thread
> http://kerneltrap.org/mailarchive/linux-kvm/2009/1/29/4848304/thread


A better long term solution might be to convert it to QLIST or something 
instead of hardcoding the array size.


> 
> Signed-off-by: Alessandro Bono <alessandro.bono@gmail.com>
> 
> --- net.h.old   2010-07-09 17:30:39.542170103 +0200
> +++ net.h       2010-07-09 17:30:48.842166029 +0200
> @@ -121,7 +121,7 @@
> 
>  /* NIC info */
> 
> -#define MAX_NICS 8
> +#define MAX_NICS 24
> 
>  struct NICInfo {
>      uint8_t macaddr[6];