From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v2] device-assignment: Better fd tracking Date: Mon, 12 Jul 2010 15:12:58 -0300 Message-ID: <20100712181258.GB8262@amt.cnet> References: <20100707162948.5414.51749.stgit@localhost.localdomain> <20100708145732.4310.85610.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, avi@redhat.com, ddutile@redhat.com To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54284 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240Ab0GLTRp (ORCPT ); Mon, 12 Jul 2010 15:17:45 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6CJHiTG019022 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 12 Jul 2010 15:17:44 -0400 Content-Disposition: inline In-Reply-To: <20100708145732.4310.85610.stgit@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Jul 08, 2010 at 08:58:32AM -0600, Alex Williamson wrote: > Commit 909bfdba fixed a hole with not closing resource file descriptors > but we need to be more careful about tracking which are real fds, > otherwise we might close fd 0, which doesn't work out so well for stdio. > > Signed-off-by: Alex Williamson > --- > > v2: fix qemu style braces > > hw/device-assignment.c | 10 ++++++---- > 1 files changed, 6 insertions(+), 4 deletions(-) Applied, thanks.