Re: [PATCH] emulator: inc/dec can have lock prefix

[Gleb Natapov <gleb@redhat.com>]

On Tue, Jul 13, 2010 at 04:54:01PM +0300, Avi Kivity wrote:
> On 07/13/2010 04:40 PM, Gleb Natapov wrote:
> >Mark inc (0xfe/0 0xff/0) and dec (0xfe/1 0xff/1) as lock prefix capable.
> >
> >Signed-off-by: Gleb Natapov<gleb@redhat.com>
> >diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> >index 255473f..b38bd8b 100644
> >--- a/arch/x86/kvm/emulate.c
> >+++ b/arch/x86/kvm/emulate.c
> >@@ -345,10 +345,10 @@ static u32 group_table[] = {
> >  	DstMem | SrcNone | ModRM, DstMem | SrcNone | ModRM,
> >  	0, 0, 0, 0,
> >  	[Group4*8] =
> >-	ByteOp | DstMem | SrcNone | ModRM, ByteOp | DstMem | SrcNone | ModRM,
> >+	ByteOp | DstMem | SrcNone | ModRM | Lock, ByteOp | DstMem | SrcNone | ModRM | Lock,
> >  	0, 0, 0, 0, 0, 0,
> >  	[Group5*8] =
> >-	DstMem | SrcNone | ModRM, DstMem | SrcNone | ModRM,
> >+	DstMem | SrcNone | ModRM | Lock, DstMem | SrcNone | ModRM | Lock,
> >  	SrcMem | ModRM | Stack, 0,
> >  	SrcMem | ModRM | Stack, SrcMemFAddr | ModRM | ImplicitOps,
> >  	SrcMem | ModRM | Stack, 0,
> 
> Right.  Please post a regression test as well (kvm/test/x86/emulator.c).
> 
OK.

> Did this occur on a real workload?
> 
Yes, RHEL6 guest on RHEL6 host without ept.

--
			Gleb.