From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Subject: Re: [Qemu-devel] [RFC PATCH 1/7] Generic IOMMU layer
Date: Thu, 15 Jul 2010 01:47:16 +0300
Message-ID: <20100714224715.GA7065@localhost>
References: <1279086307-9596-1-git-send-email-eduard.munteanu@linux360.ro>
 <1279086307-9596-2-git-send-email-eduard.munteanu@linux360.ro>
 <alpine.LNX.2.00.1007141005550.4536@linmac>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: joro@8bytes.org, qemu-devel@nongnu.org, avi@redhat.com,
	kvm@vger.kernel.org, paul@codesourcery.com
To: malc <av1474@comtv.ru>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-bw0-f46.google.com ([209.85.214.46]:58705 "EHLO
	mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754274Ab0GNWsX (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 14 Jul 2010 18:48:23 -0400
Received: by bwz1 with SMTP id 1so249600bwz.19
        for <kvm@vger.kernel.org>; Wed, 14 Jul 2010 15:48:20 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <alpine.LNX.2.00.1007141005550.4536@linmac>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Jul 14, 2010 at 10:07:20AM +0400, malc wrote:
> On Wed, 14 Jul 2010, Eduard - Gabriel Munteanu wrote:
> 
> > This provides an API for abstracting IOMMU functions. Hardware emulation
> > code can use it to request address translation and access checking. In
> > the absence of an emulated IOMMU, no translation/checking happens and
> > I/O goes through as before.
> > 
> > IOMMU emulation code must provide implementation-specific hooks for this
> > layer.
> > 
> 
> [..snip..]
> 
> > +int __iommu_rw(struct iommu *iommu,
> > +               DeviceState *dev,
> > +               target_phys_addr_t addr,
> > +               uint8_t *buf,
> > +               int len,
> > +               int is_write)
> 
> Do not use leading double underscore.
> 
> [..snip..]
> 
> -- 
> mailto:av1474@comtv.ru

Thanks, will fix it.


	Eduard