From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Subject: Re: [Qemu-devel] [RFC PATCH 3/7] pci: call IOMMU hooks
Date: Thu, 15 Jul 2010 01:50:14 +0300
Message-ID: <20100714225014.GB7065@localhost>
References: <1279086307-9596-1-git-send-email-eduard.munteanu@linux360.ro>
 <1279086307-9596-4-git-send-email-eduard.munteanu@linux360.ro>
 <20100714073739.GM31689@valinux.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: joro@8bytes.org, qemu-devel@nongnu.org, avi@redhat.com,
	kvm@vger.kernel.org, paul@codesourcery.com
To: Isaku Yamahata <yamahata@valinux.co.jp>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-bw0-f46.google.com ([209.85.214.46]:46655 "EHLO
	mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754274Ab0GNWvU (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 14 Jul 2010 18:51:20 -0400
Received: by bwz1 with SMTP id 1so250441bwz.19
        for <kvm@vger.kernel.org>; Wed, 14 Jul 2010 15:51:18 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20100714073739.GM31689@valinux.co.jp>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Jul 14, 2010 at 04:37:39PM +0900, Isaku Yamahata wrote:
> On Wed, Jul 14, 2010 at 08:45:03AM +0300, Eduard - Gabriel Munteanu wrote:

[snip]

> >  PCIDevice *pci_register_device(PCIBus *bus, const char *name,
> >                                 int instance_size, int devfn,
> >                                 PCIConfigReadFunc *config_read,
> >                                 PCIConfigWriteFunc *config_write)
> >  {
> >      PCIDevice *pci_dev;
> > +    int err;
> >  
> >      pci_dev = qemu_mallocz(instance_size);
> >      pci_dev = do_pci_register_device(pci_dev, bus, name, devfn,
> > @@ -747,6 +761,13 @@ PCIDevice *pci_register_device(PCIBus *bus, const char *name,
> >      if (pci_dev == NULL) {
> >          hw_error("PCI: can't register device\n");
> >      }
> > +
> > +    err = pci_iommu_register_device(bus, pci_dev);
> > +    if (err) {
> > +        hw_error("PCI: can't register device with IOMMU\n");
> > +        return NULL;
> > +    }
> > +
> >      return pci_dev;
> >  }
> 
> pci_register_device() is pre-qdev api.
> qdev'fied device doesn't call pci_register_device().
> So please move the initialization hook into do_pci_register_device()
> which are commonly used by pci_register_device() and pci_qdev_init().
> -- 
> yamahata

Thanks, I didn't need the functionality and missed this.


	Eduard