From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v2] KVM: x86: Call mask notifiers from pic. Date: Thu, 15 Jul 2010 23:05:49 -0300 Message-ID: <20100716020549.GE21287@amt.cnet> References: <20100715092437.GP4689@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: avi@redhat.com, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:26201 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935168Ab0GPCVc (ORCPT ); Thu, 15 Jul 2010 22:21:32 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6G2LVfU010913 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 15 Jul 2010 22:21:32 -0400 Content-Disposition: inline In-Reply-To: <20100715092437.GP4689@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Jul 15, 2010 at 12:24:37PM +0300, Gleb Natapov wrote: > If pit delivers interrupt while pic is masking it OS will never do EOI > and ack notifier will not be called so when pit will be unmasked no pit > interrupts will be delivered any more. Calling mask notifiers solves this > issue. > > Signed-off-by: Gleb Natapov Applied, thanks.