From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] KVM: x86 emulator: fix handling for unemulated instructions Date: Tue, 27 Jul 2010 18:33:16 -0300 Message-ID: <20100727213316.GA12889@amt.cnet> References: <1280058676-8367-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Mohammed Gamal To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:13321 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755389Ab0G1PFl (ORCPT ); Wed, 28 Jul 2010 11:05:41 -0400 Content-Disposition: inline In-Reply-To: <1280058676-8367-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Jul 25, 2010 at 02:51:16PM +0300, Avi Kivity wrote: > If an instruction is present in the decode tables but not in the execution > switch, it will be emulated as a NOP. An example is IRET (0xcf). > > Fix by adding default: labels to the execution switches. > > Signed-off-by: Avi Kivity > --- > arch/x86/kvm/emulate.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) Applied, thanks.