From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Roedel, Joerg" Subject: Re: [PATCH 0/8] Nested SVM unit tests Date: Wed, 28 Jul 2010 13:40:30 +0200 Message-ID: <20100728114029.GF26098@amd.com> References: <1280312307-16686-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Marcelo Tosatti , "kvm@vger.kernel.org" To: Avi Kivity Return-path: Received: from va3ehsobe005.messaging.microsoft.com ([216.32.180.31]:7924 "EHLO VA3EHSOBE006.bigfish.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751134Ab0G1LlM (ORCPT ); Wed, 28 Jul 2010 07:41:12 -0400 Content-Disposition: inline In-Reply-To: <1280312307-16686-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jul 28, 2010 at 06:18:19AM -0400, Avi Kivity wrote: > The following patchset adds a framework for nested SVM unit testing. As > you may guess, future fixes and enhancements to nested SVM will require > matching tests. Cool stuff. I guess the third test failed (vmrun intercept check), should be easy to fix. This is generally a very useful thing. > Currently, our nested SVM implementation has a 66.67% success rate using > these tests. Okay, thats the downside :-) Anyway, are KVM changes not realated to nested-svm required to pass these tests too? How about fixes for race conditions? We had bugs in the past with lost interrupts in the L2 guest which only showed up under very special conditions that may be hard to reproduce directly. They may depend on an L1 interrupt becoming pending for example. (And I think we still have one bug in this area left which is not yet root-caused) Joerg -- Joerg Roedel - AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632