From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wright Subject: Re: [PATCH 2/3] device-assignment: Always use slow mapping for PCI option ROM Date: Sat, 31 Jul 2010 09:55:35 -0700 Message-ID: <20100731165535.GB28601@x200.localdomain> References: <20100730193941.10110.92913.stgit@localhost6.localdomain6> <20100730194019.10110.21091.stgit@localhost6.localdomain6> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, ddutile@redhat.com, chrisw@redhat.com, gleb@redhat.com To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54041 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756098Ab0GaQzh (ORCPT ); Sat, 31 Jul 2010 12:55:37 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6VGtbrx024609 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 31 Jul 2010 12:55:37 -0400 Content-Disposition: inline In-Reply-To: <20100730194019.10110.21091.stgit@localhost6.localdomain6> Sender: kvm-owner@vger.kernel.org List-ID: * Alex Williamson (alex.williamson@redhat.com) wrote: > KVM doesn't support read-only mappings for MMIO space. Performance isn't > an issue for the option ROM mapping, so always use slow mapping. kvm.git > cset b4f8c249 will make kvm hang with a "Bad address" fault without this. > We can also then drop the extraneous mprotects since the guest has no way > to write to these regions. Acked-by: Chris Wright