From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wright Subject: Re: [PATCH 3/3] device-assignment: Byte-wise ROM read Date: Sat, 31 Jul 2010 10:08:31 -0700 Message-ID: <20100731170831.GC28601@x200.localdomain> References: <20100730193941.10110.92913.stgit@localhost6.localdomain6> <20100730194025.10110.47519.stgit@localhost6.localdomain6> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, ddutile@redhat.com, chrisw@redhat.com, gleb@redhat.com To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:29832 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090Ab0GaRId (ORCPT ); Sat, 31 Jul 2010 13:08:33 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6VH8Wxq016659 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 31 Jul 2010 13:08:33 -0400 Content-Disposition: inline In-Reply-To: <20100730194025.10110.47519.stgit@localhost6.localdomain6> Sender: kvm-owner@vger.kernel.org List-ID: * Alex Williamson (alex.williamson@redhat.com) wrote: > The host kernel filters the PCI option ROM, returning only bytes for > the actual ROM size, not for the whole BAR. That means we typically > do a short read of the PCI sysfs ROM file. Read it a byte at a time > so we know how much to actually copy and only skip the copy if we > get nothing. Acked-by: Chris Wright