From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [KVM timekeeping 05/35] Move TSC reset out of vmcb_init Date: Fri, 20 Aug 2010 14:08:49 -0300 Message-ID: <20100820170849.GC2937@mothafucka.localdomain> References: <1282291669-25709-1-git-send-email-zamsden@redhat.com> <1282291669-25709-6-git-send-email-zamsden@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Avi Kivity , Marcelo Tosatti , Thomas Gleixner , John Stultz , linux-kernel@vger.kernel.org To: Zachary Amsden Return-path: Content-Disposition: inline In-Reply-To: <1282291669-25709-6-git-send-email-zamsden@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Thu, Aug 19, 2010 at 10:07:19PM -1000, Zachary Amsden wrote: > The VMCB is reset whenever we receive a startup IPI, so Linux is setting > TSC back to zero happens very late in the boot process and destabilizing > the TSC. Instead, just set TSC to zero once at VCPU creation time. > > Why the separate patch? So git-bisect is your friend. > > Signed-off-by: Zachary Amsden Shouldn't we set for whatever value the BSP already has, and then the BSP to zero? Since vcpus are initialized at different times, this pretty much guarantees that the guest will have desynchronized tsc at all cases (not that if it was better before...)