From: Marcelo Tosatti <mtosatti@redhat.com>
To: Xiaotian Feng <dfeng@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Dave Hansen <dave@linux.vnet.ibm.com>,
Tim Pepper <lnxninja@linux.vnet.ibm.com>
Subject: Re: [PATCH -kvm] kvm: fix regression from rework KVM mmu_shrink() code
Date: Tue, 24 Aug 2010 10:12:46 -0300 [thread overview]
Message-ID: <20100824131246.GB26660@amt.cnet> (raw)
In-Reply-To: <1282617067-7686-1-git-send-email-dfeng@redhat.com>
On Tue, Aug 24, 2010 at 10:31:07AM +0800, Xiaotian Feng wrote:
> Latest kvm mmu_shrink code rework makes kernel changes kvm->arch.n_used_mmu_pages/
> kvm->arch.n_max_mmu_pages at kvm_mmu_free_page/kvm_mmu_alloc_page, which is called
> by kvm_mmu_commit_zap_page. So the kvm->arch.n_used_mmu_pages or
> kvm_mmu_available_pages(vcpu->kvm) is unchanged after kvm_mmu_prepare_zap_page(),
> This caused kvm_mmu_change_mmu_pages/__kvm_mmu_free_some_pages loops forever.
> Moving kvm_mmu_commit_zap_page would make the while loop performs as normal.
>
> Reported-by: Avi Kivity <avi@redhat.com>
> Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
> Tested-by: Avi Kivity <avi@redhat.com>
> Cc: Marcelo Tosatti <mtosatti@redhat.com>
> Cc: Dave Hansen <dave@linux.vnet.ibm.com>
> Cc: Tim Pepper <lnxninja@linux.vnet.ibm.com>
> ---
> arch/x86/kvm/mmu.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
Applied, thanks.
next prev parent reply other threads:[~2010-08-24 13:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 1:10 [PATCH 0/4 v2] kvm: rework KVM mmu_shrink() code Tim Pepper
2010-08-22 15:29 ` Avi Kivity
2010-08-23 10:22 ` Avi Kivity
2010-08-23 10:27 ` Avi Kivity
2010-08-23 11:11 ` Xiaotian Feng
2010-08-23 11:28 ` Avi Kivity
2010-08-23 19:53 ` Tim Pepper
2010-08-24 2:07 ` Marcelo Tosatti
2010-08-24 2:31 ` [PATCH -kvm] kvm: fix regression from " Xiaotian Feng
2010-08-24 13:12 ` Marcelo Tosatti [this message]
2010-08-24 9:50 ` [PATCH 0/4 v2] kvm: " Xiaotian Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100824131246.GB26660@amt.cnet \
--to=mtosatti@redhat.com \
--cc=dave@linux.vnet.ibm.com \
--cc=dfeng@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lnxninja@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox