From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 2/8] KVM: x86 emulator: simplify ALU block (opcodes
 00-3F) decode flags
Date: Wed, 25 Aug 2010 16:39:22 -0300
Message-ID: <20100825193922.GA31337@amt.cnet>
References: <1282561577-24491-1-git-send-email-avi@redhat.com>
 <1282561577-24491-3-git-send-email-avi@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:7876 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751726Ab0HYTvO (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 25 Aug 2010 15:51:14 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7PJpEF6003383
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <kvm@vger.kernel.org>; Wed, 25 Aug 2010 15:51:14 -0400
Content-Disposition: inline
In-Reply-To: <1282561577-24491-3-git-send-email-avi@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Aug 23, 2010 at 02:06:11PM +0300, Avi Kivity wrote:
> Use the new byte/word dual opcode decode.
> 
> Signed-off-by: Avi Kivity <avi@redhat.com>
> ---
>  arch/x86/kvm/emulate.c |   40 ++++++++++++++++------------------------
>  1 files changed, 16 insertions(+), 24 deletions(-)
> 
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 152654e..79a5f81 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -2370,42 +2370,34 @@ static struct group_dual group9 = { {
>  
>  static struct opcode opcode_table[256] = {
>  	/* 0x00 - 0x07 */
> -	D(ByteOp | DstMem | SrcReg | ModRM | Lock), D(DstMem | SrcReg | ModRM | Lock),
> -	D(ByteOp | DstReg | SrcMem | ModRM), D(DstReg | SrcMem | ModRM),
> -	D(ByteOp | DstAcc | SrcImm), D(DstAcc | SrcImm),
> +	D2bv(DstMem | SrcReg | ModRM | Lock), D2bv(DstReg | SrcMem | ModRM),
> +	D2bv(DstAcc | SrcImm),
>  	D(ImplicitOps | Stack | No64), D(ImplicitOps | Stack | No64),
>  	/* 0x08 - 0x0F */
> -	D(ByteOp | DstMem | SrcReg | ModRM | Lock), D(DstMem | SrcReg | ModRM | Lock),
> -	D(ByteOp | DstReg | SrcMem | ModRM), D(DstReg | SrcMem | ModRM),
> -	D(ByteOp | DstAcc | SrcImm), D(DstAcc | SrcImm),
> +	D2bv(DstMem | SrcReg | ModRM | Lock), D2bv(DstReg | SrcMem | ModRM),
> +	D2bv(DstAcc | SrcImm),
>  	D(ImplicitOps | Stack | No64), N,
>  	/* 0x10 - 0x17 */
> -	D(ByteOp | DstMem | SrcReg | ModRM | Lock), D(DstMem | SrcReg | ModRM | Lock),
> -	D(ByteOp | DstReg | SrcMem | ModRM), D(DstReg | SrcMem | ModRM),
> -	D(ByteOp | DstAcc | SrcImm), D(DstAcc | SrcImm),
> +	D2bv(DstMem | SrcReg | ModRM | Lock), D2bv(DstReg | SrcMem | ModRM),
> +	D2bv(DstAcc | SrcImm),
>  	D(ImplicitOps | Stack | No64), D(ImplicitOps | Stack | No64),
>  	/* 0x18 - 0x1F */
> -	D(ByteOp | DstMem | SrcReg | ModRM | Lock), D(DstMem | SrcReg | ModRM | Lock),
> -	D(ByteOp | DstReg | SrcMem | ModRM), D(DstReg | SrcMem | ModRM),
> -	D(ByteOp | DstAcc | SrcImm), D(DstAcc | SrcImm),
> +	D2bv(DstMem | SrcReg | ModRM | Lock), D2bv(DstReg | SrcMem | ModRM),
> +	D2bv(DstAcc | SrcImm),
>  	D(ImplicitOps | Stack | No64), D(ImplicitOps | Stack | No64),
>  	/* 0x20 - 0x27 */
> -	D(ByteOp | DstMem | SrcReg | ModRM | Lock), D(DstMem | SrcReg | ModRM | Lock),
> -	D(ByteOp | DstReg | SrcMem | ModRM), D(DstReg | SrcMem | ModRM),
> -	D(ByteOp | DstAcc | SrcImmByte), D(DstAcc | SrcImm), N, N,
> +	D2bv(DstMem | SrcReg | ModRM | Lock), D2bv(DstReg | SrcMem | ModRM),
> +	D2bv(DstAcc | SrcImmByte), N, N,

SrcImm? opcode 0x25...