From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] KVM: x86 emulator: fix regression with cmpxchg8b on i386 hosts Date: Thu, 26 Aug 2010 16:16:02 -0300 Message-ID: <20100826191602.GG25688@amt.cnet> References: <1282822290-8366-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50556 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752069Ab0HZUr6 (ORCPT ); Thu, 26 Aug 2010 16:47:58 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7QKlw5P020393 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 26 Aug 2010 16:47:58 -0400 Content-Disposition: inline In-Reply-To: <1282822290-8366-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Aug 26, 2010 at 02:31:30PM +0300, Avi Kivity wrote: > operand::val and operand::orig_val are 32-bit on i386, whereas cmpxchg8b > operands are 64-bit. > > Fix by adding val64 and orig_val64 union members to struct operand, and > using them where needed. > > Signed-off-by: Avi Kivity > --- > arch/x86/include/asm/kvm_emulate.h | 6 +++++- > arch/x86/kvm/emulate.c | 9 ++++----- > 2 files changed, 9 insertions(+), 6 deletions(-) Applied, thanks.