From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [RFC 4/7] change kernel accounting to include steal time Date: Thu, 26 Aug 2010 20:12:40 -0300 Message-ID: <20100826231240.GA6963@amt.cnet> References: <1282772597-4183-1-git-send-email-glommer@redhat.com> <1282772597-4183-2-git-send-email-glommer@redhat.com> <1282772597-4183-3-git-send-email-glommer@redhat.com> <1282772597-4183-4-git-send-email-glommer@redhat.com> <1282772597-4183-5-git-send-email-glommer@redhat.com> <20100826172303.GB21273@amt.cnet> <20100826202856.GC2985@mothafucka.localdomain> <4C76D947.4030105@codemonkey.ws> <20100826214036.GH2985@mothafucka.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Anthony Liguori , kvm@vger.kernel.org, avi@redhat.com, zamsden@redhat.com, riel@redhat.com To: Glauber Costa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11619 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752799Ab0HZXNi (ORCPT ); Thu, 26 Aug 2010 19:13:38 -0400 Content-Disposition: inline In-Reply-To: <20100826214036.GH2985@mothafucka.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Aug 26, 2010 at 06:40:36PM -0300, Glauber Costa wrote: > On Thu, Aug 26, 2010 at 04:14:47PM -0500, Anthony Liguori wrote: > > On 08/26/2010 03:28 PM, Glauber Costa wrote: > > > > > >>+ if (delta> 1000UL) > > >>+ touch_softlockup_watchdog(); > > >>+ > > >> > > >>This will break authentic soft lockup detection whenever qemu processing > > >>takes more than 1s. > > >This should be 10s. 1000UL is a typo. > > > > I was wondering that when I first saw the patch.. 10s is the > > default detection time but it's actually run time configurable so > > hard coding 10s is not correct. This is not what i'm referring to. The code above will disable softlockup detection in case of a vcpu blocked in qemu for longer than softlockup threshold, which is a legitimate case. > > Indeed, you are right. > > Thanks