From: Gleb Natapov <gleb@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Avi Kivity <avi@redhat.com>,
"Jes.Sorensen@redhat.com" <Jes.Sorensen@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH 1/1] Disable GUEST_INTR_STATE_STI flag before injecting NMI to guest on VMX
Date: Fri, 27 Aug 2010 14:25:39 +0300 [thread overview]
Message-ID: <20100827112539.GC21909@redhat.com> (raw)
In-Reply-To: <4C77A01A.70702@siemens.com>
On Fri, Aug 27, 2010 at 01:23:06PM +0200, Jan Kiszka wrote:
> Gleb Natapov wrote:
> > On Fri, Aug 27, 2010 at 12:44:41PM +0300, Avi Kivity wrote:
> >>> Thinking about the implications: Independent of virtualization, this
> >>> means that no code code can in any way rely on the STI shadow if there
> >>> are NMIs present that could "consume" it. Because after return from
> >>> those NMIs, interrupts could then be injected on the instruction that
> >>> was originally under the shadow.
> >>>
> >> Wow. Maybe we should request an interrupt window instead when
> >> blocked-by-STI is active instead of clearing it.
> >>
> > Wow indeed. We can remember blocked by sti state before injecting NMI
> > and request nmi window open exit. When we get nmi window open exit we
> > can restore blocked by sti flag.
>
> For sure we could. But I still wonder what happens to the shadow in such
> a scenario on real HW.
>
Me too, so lets wait for vendor answer.
--
Gleb.
next prev parent reply other threads:[~2010-08-27 11:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 20:06 [PATCH 0/1] Disable GUEST_INTR_STATE_STI flag before injecting NMI to VMX guest Jes.Sorensen
2010-08-26 20:06 ` [PATCH 1/1] Disable GUEST_INTR_STATE_STI flag before injecting NMI to guest on VMX Jes.Sorensen
2010-08-27 8:27 ` Jan Kiszka
2010-08-27 8:31 ` Jes Sorensen
2010-08-27 8:39 ` Jan Kiszka
2010-08-27 9:46 ` Avi Kivity
2010-08-27 11:06 ` Jan Kiszka
2010-08-27 13:58 ` Avi Kivity
2010-08-27 14:13 ` Jan Kiszka
2010-08-27 15:50 ` Avi Kivity
2010-08-27 16:43 ` Jan Kiszka
2010-08-29 8:09 ` Avi Kivity
2010-08-27 9:44 ` Avi Kivity
2010-08-27 11:06 ` Jan Kiszka
2010-08-27 13:54 ` Avi Kivity
2010-08-27 14:12 ` Jan Kiszka
2010-08-27 11:16 ` Gleb Natapov
2010-08-27 11:23 ` Jan Kiszka
2010-08-27 11:25 ` Gleb Natapov [this message]
2010-08-27 11:04 ` Gleb Natapov
2010-08-27 11:09 ` Jan Kiszka
2010-08-27 9:21 ` Avi Kivity
2010-08-27 9:41 ` Jes Sorensen
2010-08-27 9:47 ` Avi Kivity
2010-08-27 9:56 ` Jes Sorensen
2010-08-27 9:59 ` Avi Kivity
2010-08-27 10:01 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100827112539.GC21909@redhat.com \
--to=gleb@redhat.com \
--cc=Jes.Sorensen@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox