From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduard - Gabriel Munteanu Subject: Re: [PATCH 1/7] pci: expand tabs to spaces in pci_regs.h Date: Wed, 1 Sep 2010 01:58:30 +0300 Message-ID: <20100831225830.GA10567@localhost> References: <1283007298-10942-1-git-send-email-eduard.munteanu@linux360.ro> <1283007298-10942-2-git-send-email-eduard.munteanu@linux360.ro> <20100831202953.GF31570@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: joro@8bytes.org, blauwirbel@gmail.com, paul@codesourcery.com, avi@redhat.com, anthony@codemonkey.ws, av1474@comtv.ru, yamahata@valinux.co.jp, kvm@vger.kernel.org, qemu-devel@nongnu.org To: "Michael S. Tsirkin" Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:54156 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754637Ab0HaXAN (ORCPT ); Tue, 31 Aug 2010 19:00:13 -0400 Received: by fxm13 with SMTP id 13so4343844fxm.19 for ; Tue, 31 Aug 2010 16:00:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20100831202953.GF31570@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Aug 31, 2010 at 11:29:53PM +0300, Michael S. Tsirkin wrote: > On Sat, Aug 28, 2010 at 05:54:52PM +0300, Eduard - Gabriel Munteanu wrote: > > The conversion was done using the GNU 'expand' tool (default settings) > > to make it obey the QEMU coding style. > > > > Signed-off-by: Eduard - Gabriel Munteanu > > I'm not really interested in this: we copied pci_regs.h from linux > to help non-linux hosts, and keeping the code consistent > with the original makes detecting bugs and adding new stuff > from linux/pci_regs.h easier. > > > --- > > hw/pci_regs.h | 1330 ++++++++++++++++++++++++++++---------------------------- > > 1 files changed, 665 insertions(+), 665 deletions(-) > > rewrite hw/pci_regs.h (90%) Ok, I'll drop it. The only reason I did it was one of my additions to this file made the patch look indented awkwardly. I'll use tabs and merge it into Linux as well. Thanks, Eduard