From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 0/5] virtio-net: More configurability and bh handling for tx Date: Wed, 1 Sep 2010 13:40:25 +0300 Message-ID: <20100901104025.GC7513@redhat.com> References: <20100827223659.2696.3589.stgit@s20.home> <20100831202705.GE31570@redhat.com> <4C7D751B.8070705@codemonkey.ws> <1283293567.5826.147.camel@x201> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org, jes.sorensen@redhat.com, kraxel@redhat.com To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:9663 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752379Ab0IAKqS (ORCPT ); Wed, 1 Sep 2010 06:46:18 -0400 Content-Disposition: inline In-Reply-To: <1283293567.5826.147.camel@x201> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Aug 31, 2010 at 04:26:07PM -0600, Alex Williamson wrote: > On Tue, 2010-08-31 at 16:33 -0500, Anthony Liguori wrote: > > On 08/31/2010 03:27 PM, Michael S. Tsirkin wrote: > > > On Fri, Aug 27, 2010 at 04:36:59PM -0600, Alex Williamson wrote: > > > > > >> Add the ability to configure the tx_timer timeout and add a bottom > > >> half tx handler that typically shows a nice perf boost over the > > >> time based approach. See last patch for perf details. Make this > > >> the new default when the iothread is enabled. Thanks, > > >> > > >> Alex > > >> > > > As a further thought, maybe it would help to have a > > > separate namespace for unsupported, developer-only parameters. > > > Thoughts? > > > > > > > We already have an undocumented one, just prefix with 'x-' to indicate > > that it's experimental. > > Any objection then to x-txburst and x-txtimer then? Easy enough to > rename. Thanks, > > Alex No objection. Let's put the 256 constant in a header, with a comment explaining where it came from? -- MST