From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v2 0/4] virtio-net: More configurability and bh handling for tx Date: Thu, 2 Sep 2010 18:35:16 +0300 Message-ID: <20100902153516.GD18182@redhat.com> References: <20100902150041.11862.65901.stgit@s20.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, anthony@codemonkey.ws, chrisw@redhat.com, quintela@redhat.com, jes.sorensen@redhat.com To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:4164 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752088Ab0IBPlL (ORCPT ); Thu, 2 Sep 2010 11:41:11 -0400 Content-Disposition: inline In-Reply-To: <20100902150041.11862.65901.stgit@s20.home> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Sep 02, 2010 at 09:00:42AM -0600, Alex Williamson wrote: > Incorporated feedback. txburst= and txtimer= are now "x-" prefixed > developer options. I added a tx= option, because I do want there to > be a supported way to switch between TX strategies. This also drops > the magic value of txtimer= 1 or 0 (setting default timeout or switching > modes). I also dropped the trickiness around only enabling the bottom > half for the iothread since Anthony indicates we don't care about > performance for the non-iothread case. > > New performance data against both qemu.git and qemu-kvm.git: > > https://spreadsheets.google.com/pub?key=0AoEm50Bac2U7dGdlREhrWUpPVEdMcTJaX0RjSEgtc3c&hl=en&single=true&gid=0&output=html > > This shows the base performance versus patched with new default for > various packet sizes and netperf test loads. The guest is a 2-way > SMP, connected directly to the host via a tap (no bridge). Thanks, > > Alex ACK the series. Please remember to clone bugzilla into libvirt and ask them to support the new option on zstream/0day, so that we do have a working backup plan. > --- > > Alex Williamson (4): > virtio-net: Introduce a new bottom half packet TX > virtio-net: Rename tx_timer_active to tx_waiting > virtio-net: Limit number of packets sent per TX flush > virtio-net: Make tx_timer timeout configurable > > > hw/s390-virtio-bus.c | 8 +++ > hw/s390-virtio-bus.h | 1 > hw/syborg_virtio.c | 8 +++ > hw/virtio-net.c | 129 +++++++++++++++++++++++++++++++++++++++++--------- > hw/virtio-net.h | 14 +++++ > hw/virtio-pci.c | 8 +++ > hw/virtio.h | 4 +- > 7 files changed, 144 insertions(+), 28 deletions(-)