From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [patch 1/3] kvm test: add monitor_printf
Date: Fri, 3 Sep 2010 13:48:57 -0300
Message-ID: <20100903164857.GA31666@amt.cnet>
References: <20100902233652.853027771@redhat.com>
 <20100902233712.666073971@redhat.com>
 <4C80AA43.20904@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:28485 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755364Ab0ICQu7 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 3 Sep 2010 12:50:59 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o83Gowpr020964
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <kvm@vger.kernel.org>; Fri, 3 Sep 2010 12:50:58 -0400
Content-Disposition: inline
In-Reply-To: <4C80AA43.20904@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, Sep 03, 2010 at 09:56:51AM +0200, Paolo Bonzini wrote:
> On 09/03/2010 01:36 AM, Marcelo Tosatti wrote:
> >+static void print_monitor(const char *buf)
> >+{
> >+	[...]
> >+}
> >+
> >+void puts_monitor(const char *s)
> >+{
> >+	spin_lock(&mon_lock);
> >+	print_serial(s);
>         ^^^^^^^^^^^^
> 
> Is this intended?

Ouch, no, print_monitor.

> 
> Paolo