From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [patch 3/3] Add mce test
Date: Sun, 5 Sep 2010 18:17:22 -0300
Message-ID: <20100905211722.GA3030@amt.cnet>
References: <20100902233652.853027771@redhat.com>
 <20100902233712.767024334@redhat.com>
 <4C835194.1020002@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:7037 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754264Ab0IEVhO (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 5 Sep 2010 17:37:14 -0400
Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o85LbEPO004488
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <kvm@vger.kernel.org>; Sun, 5 Sep 2010 17:37:14 -0400
Content-Disposition: inline
In-Reply-To: <4C835194.1020002@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, Sep 05, 2010 at 11:15:16AM +0300, Avi Kivity wrote:
>  On 09/03/2010 02:36 AM, Marcelo Tosatti wrote:
> >+
> >+int main(void)
> >+{
> >+    unsigned long long status, addr;
> >+    int bank;
> >+
> >+    smp_init();
> >+    init_idt();
> >+    set_idt_entry(18, do_handle_mce);
> >+
> >+    write_cr4(read_cr4() | X86_CR4_MCE);
> >+
> >+    wrmsr(MSR_IA32_MCG_CTL, ~0ULL);
> >+    wrmsr(MSR_IA32_MC0_CTL, ~0ULL);
> >+
> >+    status = MCI_STATUS_VAL|MCI_STATUS_UC;
> >+    addr = 0x7ffffff;
> >+    bank = 0;
> >+    ex_done = 0;
> >+    /* mce cpu bank status mcgstatus addr misc */
> >+    monitor_printf("mce %d %d 0x%llx 1 0x%llx 1\n", 0, bank, status, addr);
> 
> Wow, this is really evil.
> 
> I guess it could be done more nicely via the api unit tests we
> talked about during kf2010?

I don't remember the details. What do you consider evil?