Re: [Qemu-devel] [PATCH 1/3] qemu-kvm: Invert svm-flag setting logic

Roedel, Joerg
2010-09-07T14:13:46Z

On Tue, Sep 07, 2010 at 09:51:33AM -0400, Avi Kivity wrote:
> On 09/07/2010 03:23 PM, Alexander Graf wrote:
> >
> > I think we should get rid of kvm_nested and -enable-nesting. Instead, we should enable the SVM bit in the "host" and "qemu64" cpu types, but not in "kvm64". This way users are safe to not use nested svm, but can choose to do so if they like.
> >
> > Also, it should be possible to do something like -cpu kvm64,flags=+svm. Without having to mess with -enable-nesting.
>
> I agree, -enable-nesting is redundant with -cpu ,+svm.

This patchset makes -enable-nesting pratically a synonym for -cpu ,+svm.
So we can safely remove -enable-nesting in the future.

Joerg

--
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632