From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Roedel, Joerg" Subject: Re: [Qemu-devel] [PATCH 1/3] qemu-kvm: Invert svm-flag setting logic Date: Tue, 7 Sep 2010 16:12:17 +0200 Message-ID: <20100907141216.GA2177@amd.com> References: <1283858843-21330-1-git-send-email-joerg.roedel@amd.com> <1283858843-21330-2-git-send-email-joerg.roedel@amd.com> <4C864365.30301@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Alexander Graf , Marcelo Tosatti , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" To: Avi Kivity Return-path: Received: from tx2ehsobe005.messaging.microsoft.com ([65.55.88.15]:34085 "EHLO TX2EHSOBE010.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751320Ab0IGONq (ORCPT ); Tue, 7 Sep 2010 10:13:46 -0400 Content-Disposition: inline In-Reply-To: <4C864365.30301@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Sep 07, 2010 at 09:51:33AM -0400, Avi Kivity wrote: > On 09/07/2010 03:23 PM, Alexander Graf wrote: > > > > I think we should get rid of kvm_nested and -enable-nesting. Instead, we should enable the SVM bit in the "host" and "qemu64" cpu types, but not in "kvm64". This way users are safe to not use nested svm, but can choose to do so if they like. > > > > Also, it should be possible to do something like -cpu kvm64,flags=+svm. Without having to mess with -enable-nesting. > > I agree, -enable-nesting is redundant with -cpu ,+svm. This patchset makes -enable-nesting pratically a synonym for -cpu ,+svm. So we can safely remove -enable-nesting in the future. Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632