From mboxrd@z Thu Jan 1 00:00:00 1970 From: pradeepkumar Subject: Device hotplug issues Date: Tue, 7 Sep 2010 18:07:02 +0530 Message-ID: <20100907180702.41d6e757@skywalker-laptop> References: <4C85C9A2.2040701@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: rharper@us.ibm.com, skannery@in.ibm.com, kvm-devel , qemu-devel@nongnu.org To: Avi Kivity Return-path: Received: from e36.co.us.ibm.com ([32.97.110.154]:44245 "EHLO e36.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756256Ab0IGMhK (ORCPT ); Tue, 7 Sep 2010 08:37:10 -0400 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e36.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id o87CXGOx018746 for ; Tue, 7 Sep 2010 06:33:16 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o87Cb99r217084 for ; Tue, 7 Sep 2010 06:37:09 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o87Cb8k2027312 for ; Tue, 7 Sep 2010 06:37:09 -0600 In-Reply-To: <4C85C9A2.2040701@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Hi I tried to add a device to guest from upstream qemu monitor using "device_add". when i try to add VGA, vmware-svga..etc, from qemu monitor my qemu monitor is aborted, Since these devices already registered. I dont see a reason to kill monitor. I think abort() is a bit rough. we need a better way to handle it. If a user try to add a already registered device, qemu should convey this to user saying that, this device already registered and an error message should be fine than aborting qemu. QLIST_FOREACH(block, &ram_list.blocks, next) { if (!strcmp(block->idstr, new_block->idstr)) { fprintf(stderr, "RAMBlock \"%s\" already registered, abort!\n", new_block->idstr); abort(); } Thanks Pradeep