From: Sheng Yang <sheng@linux.intel.com>
To: kvm@vger.kernel.org
Cc: Avi Kivity <avi@redhat.com>, Hillf Danton <dhillf@gmail.com>,
"Ben-Ami Yassour" <benami@il.ibm.com>,
Amit Shah <amit.shah@redhat.com>, Yaniv Kamay <ykamay@redhat.com>
Subject: Re: [PATCH] KVM: x86: fixup set_efer()
Date: Thu, 9 Sep 2010 16:37:19 +0800 [thread overview]
Message-ID: <201009091637.19440.sheng@linux.intel.com> (raw)
In-Reply-To: <4C875FA2.40004@redhat.com>
On Wednesday 08 September 2010 18:04:18 Avi Kivity wrote:
> On 09/04/2010 04:29 PM, Hillf Danton wrote:
> > The second call to kvm_mmu_reset_context() seems unnecessary and is
> > removed.
> >
> >
> > @@ -783,10 +783,6 @@ static int set_efer(struct kvm_vcpu *vcp
> > vcpu->arch.mmu.base_role.nxe = (efer & EFER_NX) && !tdp_enabled;
> > kvm_mmu_reset_context(vcpu);
> > - /* Update reserved bits */
> > - if ((efer ^ old_efer) & EFER_NX)
> > - kvm_mmu_reset_context(vcpu);
> > -
> > return 0;
> >
> > }
>
> Hm. As far as I can tell, it's the first call that is unnecessary.
> I'll look at the history and try to understand why it was introduced.
Oops, seems my patch failed to remove the old line...
--
regards
Yang, Sheng
prev parent reply other threads:[~2010-09-09 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTinMZiG6iGBv+PHBw_rsn1+SJaPtDA=-zHcU0Mrf@mail.gmail.com>
2010-09-08 10:04 ` [PATCH] KVM: x86: fixup set_efer() Avi Kivity
2010-09-09 8:37 ` Sheng Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009091637.19440.sheng@linux.intel.com \
--to=sheng@linux.intel.com \
--cc=amit.shah@redhat.com \
--cc=avi@redhat.com \
--cc=benami@il.ibm.com \
--cc=dhillf@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=ykamay@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox